/* * SonarQube Java * Copyright (C) 2012-2016 SonarSource SA * mailto:contact AT sonarsource DOT com * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 3 of the License, or (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public License * along with this program; if not, write to the Free Software Foundation, * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ package org.sonar.java.filters; import com.google.common.collect.ImmutableSet; import com.google.common.collect.Lists; import com.google.common.collect.Multimap; import org.assertj.core.api.AbstractBooleanAssert; import org.junit.Before; import org.junit.Test; import org.sonar.api.rule.RuleKey; import org.sonar.api.scan.issue.filter.FilterableIssue; import org.sonar.check.Rule; import org.sonar.java.ast.JavaAstScanner; import org.sonar.java.model.VisitorsBridgeForTests; import org.sonar.plugins.java.api.JavaCheck; import org.sonar.plugins.java.api.tree.ClassTree; import org.sonar.plugins.java.api.tree.IdentifierTree; import org.sonar.plugins.java.api.tree.VariableTree; import javax.annotation.Nullable; import java.io.File; import java.util.List; import java.util.Set; import static org.assertj.core.api.Assertions.assertThat; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; public class BaseTreeVisitorIssueFilterTest { private static final String REPOSITORY_KEY = "octopus"; private static final String COMPONENT_KEY = "test:test.MyTest"; private static final String RULE_KEY = "S42"; private BaseTreeVisitorIssueFilter filter; private FilterableIssue issue; @Before public void setup() { issue = mock(FilterableIssue.class); when(issue.componentKey()).thenReturn(COMPONENT_KEY); when(issue.ruleKey()).thenReturn(RuleKey.of(REPOSITORY_KEY, RULE_KEY)); filter = new FakeJavaIssueFilterOnClassAndVariable(); filter.setComponentKey(COMPONENT_KEY); scanFile(filter); } @Test public void issues_by_targeted_rule_should_be_filtered() { // issue on file assertThatIssueWillBeAccepted(null).isTrue(); // issue on class ignored only if class is called "AllowedClassName" assertThatIssueWillBeAccepted(3).isFalse(); assertThatIssueWillBeAccepted(14).isTrue(); // issue on variable filtered assertThatIssueWillBeAccepted(4).isFalse(); assertThatIssueWillBeAccepted(5).isFalse(); } @Test public void issues_from_non_targeted_rules_are_accepted() { // other rule when(issue.ruleKey()).thenReturn(RuleKey.of(REPOSITORY_KEY, "OtherRule")); // issue on file accepted assertThatIssueWillBeAccepted(null).isTrue(); // issue on class accepted assertThatIssueWillBeAccepted(3).isTrue(); assertThatIssueWillBeAccepted(14).isTrue(); // issue on variable accepted assertThatIssueWillBeAccepted(4).isTrue(); assertThatIssueWillBeAccepted(5).isTrue(); } @Test public void excluded_lines_are_correct() { Multimap<String, Integer> excludedLinesByRule = filter.excludedLinesByRule(); assertThat(excludedLinesByRule).isNotNull(); assertThat(excludedLinesByRule.isEmpty()).isFalse(); assertThat(excludedLinesByRule.keySet()).containsOnly(RULE_KEY); assertThat(excludedLinesByRule.get(RULE_KEY)).containsOnly(3, 4, 5, 6, 7, 8, 9, 10, 11, 15); } @Test public void excluded_lines_by_rule_never_returns_null() { // no effect filter filter = new BaseTreeVisitorIssueFilter() { @Override public Set<Class<? extends JavaCheck>> filteredRules() { return ImmutableSet.of(); } }; // no component is set scanFile(filter); Multimap<String, Integer> excludedLinesByRule = filter.excludedLinesByRule(); assertThat(excludedLinesByRule).isNotNull(); assertThat(excludedLinesByRule.isEmpty()).isTrue(); } @Test public void issues_from_other_component_are_accepted() { // targeted rule when(issue.componentKey()).thenReturn("UnknownComponent"); // issue on file accepted assertThatIssueWillBeAccepted(null).isTrue(); // issue on class accepted assertThatIssueWillBeAccepted(3).isTrue(); assertThatIssueWillBeAccepted(14).isTrue(); // issue on variable accepted assertThatIssueWillBeAccepted(4).isTrue(); assertThatIssueWillBeAccepted(5).isTrue(); } private AbstractBooleanAssert<?> assertThatIssueWillBeAccepted(@Nullable Integer line) { when(issue.line()).thenReturn(line); return assertThat(filter.accept(issue)); } private static class FakeJavaIssueFilterOnClassAndVariable extends BaseTreeVisitorIssueFilter { @Override public Set<Class<? extends JavaCheck>> filteredRules() { return ImmutableSet.<Class<? extends JavaCheck>>of(FakeRule.class, FakeRuleWithoutKey.class); } @Override public void visitVariable(VariableTree tree) { excludeLines(tree, FakeRule.class); super.visitVariable(tree); } @Override public void visitClass(ClassTree tree) { IdentifierTree simpleName = tree.simpleName(); if (simpleName == null) { // force check on null tree excludeLines(simpleName, FakeRuleWithoutKey.class); } else if ("AllowedClassName".equals(simpleName.name())) { acceptLines(simpleName, FakeRule.class); } else { excludeLines(simpleName, FakeRule.class); } super.visitClass(tree); } } @Rule(key = RULE_KEY) private static class FakeRule implements JavaCheck { } private static class FakeRuleWithoutKey implements JavaCheck { } private static void scanFile(JavaIssueFilter filter) { List<JavaCheck> visitors = Lists.<JavaCheck>newArrayList(filter); VisitorsBridgeForTests visitorsBridge = new VisitorsBridgeForTests(visitors, Lists.<File>newLinkedList(), null); JavaAstScanner.scanSingleFileForTests(new File("src/test/files/filters/BaseTreeVisitorIssueFilter.java"), visitorsBridge); } }