/* * SonarQube Java * Copyright (C) 2012-2016 SonarSource SA * mailto:contact AT sonarsource DOT com * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 3 of the License, or (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public License * along with this program; if not, write to the Free Software Foundation, * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ package org.sonar.java.checks; import com.google.common.collect.ImmutableList; import org.sonar.check.Rule; import org.sonar.java.RspecKey; import org.sonar.plugins.java.api.IssuableSubscriptionVisitor; import org.sonar.plugins.java.api.JavaFileScannerContext; import org.sonar.plugins.java.api.tree.ArrayAccessExpressionTree; import org.sonar.plugins.java.api.tree.LiteralTree; import org.sonar.plugins.java.api.tree.ParenthesizedTree; import org.sonar.plugins.java.api.tree.Tree; import org.sonar.plugins.java.api.tree.Tree.Kind; import java.util.Arrays; import java.util.Deque; import java.util.LinkedList; import java.util.List; @Rule(key = "UselessParenthesesCheck") @RspecKey("S1110") public class UselessParenthesesCheck extends IssuableSubscriptionVisitor { private final Deque<Tree> parent = new LinkedList<>(); private static final Kind[] PARENT_EXPRESSION = { Kind.ANNOTATION, Kind.LIST, Kind.ARRAY_ACCESS_EXPRESSION, Kind.ARRAY_DIMENSION, Kind.ASSERT_STATEMENT, Kind.ASSIGNMENT, Kind.CASE_LABEL, Kind.CONDITIONAL_EXPRESSION, Kind.DO_STATEMENT, Kind.EXPRESSION_STATEMENT, Kind.FOR_EACH_STATEMENT, Kind.FOR_STATEMENT, Kind.IF_STATEMENT, Kind.LAMBDA_EXPRESSION, Kind.ARGUMENTS, Kind.METHOD, Kind.NEW_ARRAY, Kind.NEW_CLASS, Kind.PARENTHESIZED_EXPRESSION, Kind.RETURN_STATEMENT, Kind.SWITCH_STATEMENT, Kind.SYNCHRONIZED_STATEMENT, Kind.THROW_STATEMENT, Kind.VARIABLE, Kind.WHILE_STATEMENT }; @Override public void scanFile(JavaFileScannerContext context) { parent.clear(); super.scanFile(context); } @Override public void visitNode(Tree tree) { if(tree.is(Kind.PARENTHESIZED_EXPRESSION) && hasParentExpression((ParenthesizedTree) tree)) { reportIssue(((ParenthesizedTree) tree).openParenToken(), "Remove those useless parentheses.", ImmutableList.of(new JavaFileScannerContext.Location("Original", ((ParenthesizedTree) tree).closeParenToken())), null); } parent.push(tree); } private boolean hasParentExpression(ParenthesizedTree tree) { Tree parentTree = this.parent.peek(); if(parentTree.is(Kind.CONDITIONAL_EXPRESSION)) { return tree.expression().is(Kind.METHOD_INVOCATION, Kind.IDENTIFIER, Kind.MEMBER_SELECT) || tree.expression() instanceof LiteralTree; } //Exclude expression of array access expression if (parentTree.is(Kind.ARRAY_ACCESS_EXPRESSION) && tree.equals(((ArrayAccessExpressionTree) parentTree).expression())) { return false; } return parentTree.is(PARENT_EXPRESSION); } @Override public void leaveNode(Tree tree) { parent.pop(); } @Override public List<Kind> nodesToVisit() { return Arrays.asList(Kind.values()); } }