/* * SonarQube Java * Copyright (C) 2012-2016 SonarSource SA * mailto:contact AT sonarsource DOT com * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 3 of the License, or (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public License * along with this program; if not, write to the Free Software Foundation, * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ package org.sonar.java.checks; import com.google.common.collect.ImmutableList; import org.apache.commons.lang.BooleanUtils; import org.sonar.check.Rule; import org.sonar.java.checks.helpers.MethodsHelper; import org.sonar.java.matcher.MethodMatcher; import org.sonar.plugins.java.api.IssuableSubscriptionVisitor; import org.sonar.plugins.java.api.tree.ClassTree; import org.sonar.plugins.java.api.tree.MethodInvocationTree; import org.sonar.plugins.java.api.tree.Tree; import org.sonar.plugins.java.api.tree.Tree.Kind; import java.util.Deque; import java.util.LinkedList; import java.util.List; @Rule(key = "S2693") public class ThreadStartedInConstructorCheck extends IssuableSubscriptionVisitor { private static final MethodMatcher THREAD_START = MethodMatcher.create() .typeDefinition("java.lang.Thread") .name("start") .withoutParameter(); private final Deque<Boolean> inMethodOrStaticInitializerOrFinalClass = new LinkedList<>(); @Override public List<Kind> nodesToVisit() { return ImmutableList.of(Tree.Kind.CLASS, Tree.Kind.METHOD, Tree.Kind.METHOD_INVOCATION, Tree.Kind.STATIC_INITIALIZER); } @Override public void visitNode(Tree tree) { if (hasSemantic()) { if (tree.is(Tree.Kind.CLASS)) { inMethodOrStaticInitializerOrFinalClass.push(((ClassTree) tree).symbol().isFinal()); } else if (tree.is(Tree.Kind.METHOD, Tree.Kind.STATIC_INITIALIZER)) { inMethodOrStaticInitializerOrFinalClass.push(Boolean.TRUE); } else if (BooleanUtils.isFalse(inMethodOrStaticInitializerOrFinalClass.peek()) && THREAD_START.matches((MethodInvocationTree) tree)) { reportIssue(MethodsHelper.methodName((MethodInvocationTree) tree), "Move this \"start\" call to another method."); } } } @Override public void leaveNode(Tree tree) { if (hasSemantic() && tree.is(Tree.Kind.CLASS, Tree.Kind.METHOD, Tree.Kind.STATIC_INITIALIZER)) { inMethodOrStaticInitializerOrFinalClass.pop(); } } }