/* * SonarQube Java * Copyright (C) 2012-2016 SonarSource SA * mailto:contact AT sonarsource DOT com * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 3 of the License, or (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public License * along with this program; if not, write to the Free Software Foundation, * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ package org.sonar.java.checks.naming; import com.google.common.collect.ImmutableList; import org.sonar.check.Rule; import org.sonar.check.RuleProperty; import org.sonar.java.RspecKey; import org.sonar.java.checks.serialization.SerializableContract; import org.sonar.java.resolve.JavaType; import org.sonar.plugins.java.api.IssuableSubscriptionVisitor; import org.sonar.plugins.java.api.JavaFileScannerContext; import org.sonar.plugins.java.api.semantic.Type; import org.sonar.plugins.java.api.tree.ClassTree; import org.sonar.plugins.java.api.tree.Modifier; import org.sonar.plugins.java.api.tree.ModifierKeywordTree; import org.sonar.plugins.java.api.tree.Tree; import org.sonar.plugins.java.api.tree.VariableTree; import java.util.List; import java.util.regex.Pattern; @Rule(key = "S00115") @RspecKey("S115") public class BadConstantNameCheck extends IssuableSubscriptionVisitor { private static final String DEFAULT_FORMAT = "^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"; @RuleProperty( key = "format", description = "Regular expression used to check the constant names against.", defaultValue = "" + DEFAULT_FORMAT) public String format = DEFAULT_FORMAT; private Pattern pattern = null; @Override public List<Tree.Kind> nodesToVisit() { return ImmutableList.of(Tree.Kind.CLASS, Tree.Kind.ENUM, Tree.Kind.INTERFACE, Tree.Kind.ANNOTATION_TYPE); } @Override public void scanFile(JavaFileScannerContext context) { if (pattern == null) { pattern = Pattern.compile(format, Pattern.DOTALL); } super.scanFile(context); } @Override public void visitNode(Tree tree) { ClassTree classTree = (ClassTree) tree; for (Tree member : classTree.members()) { if (member.is(Tree.Kind.VARIABLE) && hasSemantic()) { VariableTree variableTree = (VariableTree) member; Type symbolType = variableTree.type().symbolType(); if (isConstantType(symbolType) && (classTree.is(Tree.Kind.INTERFACE, Tree.Kind.ANNOTATION_TYPE) || isStaticFinal(variableTree))) { checkName(variableTree); } } else if (member.is(Tree.Kind.ENUM_CONSTANT)) { checkName((VariableTree) member); } } } private static boolean isConstantType(Type symbolType) { return symbolType.isPrimitive() || symbolType.is("java.lang.String") || ((JavaType) symbolType).isPrimitiveWrapper(); } private void checkName(VariableTree variableTree) { if (!SerializableContract.SERIAL_VERSION_UID_FIELD.equals(variableTree.simpleName().name()) && !pattern.matcher(variableTree.simpleName().name()).matches()) { reportIssue(variableTree.simpleName(), "Rename this constant name to match the regular expression '" + format + "'."); } } private static boolean isStaticFinal(VariableTree variableTree) { boolean isStatic = false; boolean isFinal = false; for (ModifierKeywordTree modifierKeywordTree : variableTree.modifiers().modifiers()) { Modifier modifier = modifierKeywordTree.modifier(); if (modifier == Modifier.STATIC) { isStatic = true; } if (modifier == Modifier.FINAL) { isFinal = true; } } return isStatic && isFinal; } }