/* * SonarQube Java * Copyright (C) 2012-2016 SonarSource SA * mailto:contact AT sonarsource DOT com * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 3 of the License, or (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public License * along with this program; if not, write to the Free Software Foundation, * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ package org.sonar.java.checks; import com.google.common.collect.ImmutableList; import java.util.List; import org.sonar.check.Rule; import org.sonar.java.matcher.MethodMatcher; import org.sonar.java.matcher.TypeCriteria; import org.sonar.java.model.ExpressionUtils; import org.sonar.plugins.java.api.IssuableSubscriptionVisitor; import org.sonar.plugins.java.api.semantic.Symbol; import org.sonar.plugins.java.api.tree.BaseTreeVisitor; import org.sonar.plugins.java.api.tree.BinaryExpressionTree; import org.sonar.plugins.java.api.tree.ConditionalExpressionTree; import org.sonar.plugins.java.api.tree.ExpressionTree; import org.sonar.plugins.java.api.tree.IdentifierTree; import org.sonar.plugins.java.api.tree.IfStatementTree; import org.sonar.plugins.java.api.tree.InstanceOfTree; import org.sonar.plugins.java.api.tree.MemberSelectExpressionTree; import org.sonar.plugins.java.api.tree.MethodInvocationTree; import org.sonar.plugins.java.api.tree.MethodTree; import org.sonar.plugins.java.api.tree.Tree; import org.sonar.plugins.java.api.tree.TypeCastTree; @Rule(key = "S2097") public class EqualsArgumentTypeCheck extends IssuableSubscriptionVisitor { private static final MethodMatcher EQUALS_MATCHER = MethodMatcher.create() .name("equals") .addParameter(TypeCriteria.anyType()); private static final MethodMatcher GETCLASS_MATCHER = MethodMatcher.create() .name("getClass") .withoutParameter(); @Override public List<Tree.Kind> nodesToVisit() { return ImmutableList.of(Tree.Kind.METHOD); } @Override public void visitNode(Tree tree) { if (!hasSemantic()) { return; } MethodTree methodTree = (MethodTree) tree; if (methodTree.block() != null && "equals".equals(methodTree.symbol().name()) && methodTree.parameters().size() == 1) { Symbol parameterSymbol = methodTree.parameters().get(0).symbol(); if (parameterSymbol.type().is("java.lang.Object")) { CastVisitor castVisitor = new CastVisitor(parameterSymbol); methodTree.accept(castVisitor); if (castVisitor.hasUncheckedCast) { reportIssue(methodTree.simpleName(), "Add a type test to this method."); } } } } private static boolean isArgument(ExpressionTree tree, Symbol parameterSymbol) { ExpressionTree expressionTree = ExpressionUtils.skipParentheses(tree); return expressionTree.is(Tree.Kind.IDENTIFIER) && ((IdentifierTree) expressionTree).symbol().equals(parameterSymbol); } private static class CastVisitor extends BaseTreeVisitor { private final Symbol parameterSymbol; boolean typeChecked = false; boolean hasUncheckedCast = false; public CastVisitor(Symbol parameterSymbol) { this.parameterSymbol = parameterSymbol; } @Override public void visitBinaryExpression(BinaryExpressionTree tree) { if (tree.is(Tree.Kind.CONDITIONAL_AND)) { ExpressionVisitor expressionVisitor = new ExpressionVisitor(parameterSymbol); tree.leftOperand().accept(expressionVisitor); if (expressionVisitor.typeChecked) { typeChecked = true; return; } scan(tree.rightOperand()); } else { super.visitBinaryExpression(tree); } } @Override public void visitConditionalExpression(ConditionalExpressionTree tree) { ExpressionVisitor expressionVisitor = new ExpressionVisitor(parameterSymbol); tree.condition().accept(expressionVisitor); if (expressionVisitor.typeChecked) { typeChecked = true; return; } scan(tree.trueExpression()); scan(tree.falseExpression()); } @Override public void visitIfStatement(IfStatementTree tree) { ExpressionVisitor expressionVisitor = new ExpressionVisitor(parameterSymbol); tree.condition().accept(expressionVisitor); if (expressionVisitor.typeChecked) { typeChecked = true; return; } scan(tree.thenStatement()); scan(tree.elseStatement()); } @Override public void visitTypeCast(TypeCastTree tree) { if (isArgument(tree.expression(), parameterSymbol) && !typeChecked) { hasUncheckedCast = true; } else { super.visitTypeCast(tree); } } } private static class ExpressionVisitor extends BaseTreeVisitor { private final Symbol parameterSymbol; private boolean typeChecked; ExpressionVisitor(Symbol parameterSymbol) { this.parameterSymbol = parameterSymbol; } @Override public void visitInstanceOf(InstanceOfTree tree) { if (isArgument(tree.expression(), parameterSymbol)) { typeChecked = true; } } @Override public void visitBinaryExpression(BinaryExpressionTree tree) { if (tree.is(Tree.Kind.EQUAL_TO, Tree.Kind.NOT_EQUAL_TO) && (isGetClassOnArgument(tree.leftOperand()) || isGetClassOnArgument(tree.rightOperand()))) { typeChecked = true; } else { super.visitBinaryExpression(tree); } } @Override public void visitMethodInvocation(MethodInvocationTree tree) { if (EQUALS_MATCHER.matches(tree)) { ExpressionTree methodSelect = tree.methodSelect(); if ((methodSelect.is(Tree.Kind.MEMBER_SELECT) && isGetClassOnArgument(((MemberSelectExpressionTree) methodSelect).expression())) || isGetClassOnArgument(tree.arguments().get(0))) { typeChecked = true; return; } } for (ExpressionTree argument : tree.arguments()) { if (isArgument(argument, parameterSymbol)) { typeChecked = true; return; } } super.visitMethodInvocation(tree); } private boolean isGetClassOnArgument(ExpressionTree tree) { ExpressionTree expressionTree = ExpressionUtils.skipParentheses(tree); return expressionTree.is(Tree.Kind.METHOD_INVOCATION) && GETCLASS_MATCHER.matches((MethodInvocationTree) expressionTree) && isInvocationOnArgument((MethodInvocationTree) expressionTree); } private boolean isInvocationOnArgument(MethodInvocationTree tree) { return tree.methodSelect().is(Tree.Kind.MEMBER_SELECT) && isArgument(((MemberSelectExpressionTree) tree.methodSelect()).expression(), parameterSymbol); } } }