// Copyright 2015 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.analysis;
import static com.google.common.truth.Truth.assertThat;
import static com.google.common.truth.Truth.assertWithMessage;
import static com.google.devtools.build.lib.testutil.MoreAsserts.assertEventCount;
import static com.google.devtools.build.lib.testutil.MoreAsserts.assertEventCountAtLeast;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import com.google.common.base.Function;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import com.google.common.collect.Sets;
import com.google.common.eventbus.EventBus;
import com.google.common.truth.Truth;
import com.google.devtools.build.lib.actions.Action;
import com.google.devtools.build.lib.actions.Actions;
import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.actions.FailAction;
import com.google.devtools.build.lib.analysis.BuildView.AnalysisResult;
import com.google.devtools.build.lib.analysis.config.BuildConfiguration;
import com.google.devtools.build.lib.analysis.config.InvalidConfigurationException;
import com.google.devtools.build.lib.analysis.util.AnalysisMock;
import com.google.devtools.build.lib.analysis.util.BuildViewTestBase;
import com.google.devtools.build.lib.analysis.util.ExpectedDynamicConfigurationErrors;
import com.google.devtools.build.lib.cmdline.Label;
import com.google.devtools.build.lib.packages.Attribute;
import com.google.devtools.build.lib.packages.Rule;
import com.google.devtools.build.lib.skyframe.SkyFunctions;
import com.google.devtools.build.lib.skyframe.TargetPatternValue.TargetPatternKey;
import com.google.devtools.build.lib.testutil.Suite;
import com.google.devtools.build.lib.testutil.TestSpec;
import com.google.devtools.build.lib.testutil.TestUtils;
import com.google.devtools.build.lib.util.Pair;
import com.google.devtools.build.lib.vfs.Path;
import com.google.devtools.build.lib.vfs.PathFragment;
import com.google.devtools.build.skyframe.NotifyingHelper.EventType;
import com.google.devtools.build.skyframe.NotifyingHelper.Listener;
import com.google.devtools.build.skyframe.NotifyingHelper.Order;
import com.google.devtools.build.skyframe.SkyKey;
import com.google.devtools.build.skyframe.TrackingAwaiter;
import com.google.devtools.common.options.Options;
import com.google.devtools.common.options.OptionsParsingException;
import java.util.ArrayList;
import java.util.Collection;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.regex.Pattern;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/**
* Tests for the {@link BuildView}.
*/
@TestSpec(size = Suite.SMALL_TESTS)
@RunWith(JUnit4.class)
public class BuildViewTest extends BuildViewTestBase {
private static final Function<AnalysisFailureEvent, Pair<String, String>>
ANALYSIS_EVENT_TO_STRING_PAIR = new Function<AnalysisFailureEvent, Pair<String, String>>() {
@Override
public Pair<String, String> apply(AnalysisFailureEvent event) {
return Pair.of(
event.getFailedTarget().getLabel().toString(), event.getFailureReason().toString());
}
};
@Test
public void testRuleConfiguredTarget() throws Exception {
scratch.file("pkg/BUILD",
"genrule(name='foo', ",
" cmd = '',",
" srcs=['a.src'],",
" outs=['a.out'])");
update("//pkg:foo");
Rule ruleTarget = (Rule) getTarget("//pkg:foo");
assertEquals("genrule", ruleTarget.getRuleClass());
ConfiguredTarget ruleCT = getConfiguredTarget("//pkg:foo");
assertSame(ruleTarget, ruleCT.getTarget());
}
@Test
public void testFilterByTargets() throws Exception {
scratch.file("tests/BUILD",
"sh_test(name = 'small_test_1',",
" srcs = ['small_test_1.sh'],",
" data = [':xUnit'],",
" size = 'small',",
" tags = ['tag1'])",
"",
"sh_test(name = 'small_test_2',",
" srcs = ['small_test_2.sh'],",
" size = 'small',",
" tags = ['tag2'])",
"",
"",
"test_suite( name = 'smallTests', tags=['small'])");
//scratch.file("tests/small_test_1.py");
update("//tests:smallTests");
ConfiguredTarget test1 = getConfiguredTarget("//tests:small_test_1");
ConfiguredTarget test2 = getConfiguredTarget("//tests:small_test_2");
ConfiguredTarget suite = getConfiguredTarget("//tests:smallTests");
assertNoEvents(); // start from a clean slate
Collection<ConfiguredTarget> targets =
new LinkedHashSet<>(ImmutableList.of(test1, test2, suite));
targets = Lists.<ConfiguredTarget>newArrayList(
BuildView.filterTestsByTargets(targets,
Sets.newHashSet(test1.getTarget(), suite.getTarget())));
assertThat(targets).containsExactlyElementsIn(Sets.newHashSet(test1, suite));
}
@Test
public void testSourceArtifact() throws Exception {
setupDummyRule();
update("//pkg:a.src");
InputFileConfiguredTarget inputCT = getInputFileConfiguredTarget("//pkg:a.src");
Artifact inputArtifact = inputCT.getArtifact();
assertNull(getGeneratingAction(inputArtifact));
assertEquals("pkg/a.src", inputArtifact.getExecPathString());
}
@Test
public void testGeneratedArtifact() throws Exception {
setupDummyRule();
update("//pkg:a.out");
OutputFileConfiguredTarget outputCT = (OutputFileConfiguredTarget)
getConfiguredTarget("//pkg:a.out");
Artifact outputArtifact = outputCT.getArtifact();
assertEquals(
outputCT.getConfiguration().getBinDirectory(
outputCT.getTarget().getLabel().getPackageIdentifier().getRepository()),
outputArtifact.getRoot());
assertEquals(outputCT.getConfiguration().getBinFragment().getRelative("pkg/a.out"),
outputArtifact.getExecPath());
assertEquals(PathFragment.create("pkg/a.out"), outputArtifact.getRootRelativePath());
Action action = getGeneratingAction(outputArtifact);
assertSame(FailAction.class, action.getClass());
}
@Test
public void testSyntaxErrorInDepPackage() throws Exception {
// Check that a loading error in a dependency is properly reported.
scratch.file("a/BUILD",
"genrule(name='x',",
" srcs = ['file.txt'],",
" outs = ['foo'],",
" cmd = 'echo')",
"@"); // syntax error
scratch.file("b/BUILD",
"genrule(name= 'cc',",
" tools = ['//a:x'],",
" outs = ['bar'],",
" cmd = 'echo')");
reporter.removeHandler(failFastHandler);
EventBus eventBus = new EventBus();
AnalysisResult result = update(eventBus, defaultFlags().with(Flag.KEEP_GOING), "//b:cc");
assertContainsEvent("invalid character: '@'");
assertThat(result.hasError()).isTrue();
}
@Test
public void testReportsAnalysisRootCauses() throws Exception {
scratch.file("private/BUILD",
"genrule(",
" name='private',",
" outs=['private.out'],",
" cmd='',",
" visibility=['//visibility:private'])");
scratch.file("foo/BUILD",
"genrule(",
" name='foo',",
" tools=[':bar'],",
" outs=['foo.out'],",
" cmd='')",
"genrule(",
" name='bar',",
" tools=['//private'],",
" outs=['bar.out'],",
" cmd='')");
reporter.removeHandler(failFastHandler);
EventBus eventBus = new EventBus();
AnalysisFailureRecorder recorder = new AnalysisFailureRecorder();
eventBus.register(recorder);
AnalysisResult result = update(eventBus, defaultFlags().with(Flag.KEEP_GOING), "//foo");
assertThat(result.hasError()).isTrue();
assertThat(recorder.events).hasSize(1);
AnalysisFailureEvent event = recorder.events.get(0);
assertEquals("//foo:bar", event.getFailureReason().toString());
assertEquals("//foo:foo", event.getFailedTarget().getLabel().toString());
}
@Test
public void testReportsLoadingRootCauses() throws Exception {
// This test checks that two simultaneous errors are both reported:
// - missing outs attribute,
// - package referenced in tools does not exist
scratch.file("pkg/BUILD",
"genrule(name='foo',",
" tools=['//nopackage:missing'],",
" cmd='')");
reporter.removeHandler(failFastHandler);
EventBus eventBus = new EventBus();
LoadingFailureRecorder recorder = new LoadingFailureRecorder();
eventBus.register(recorder);
// Note: no need to run analysis for a loading failure.
AnalysisResult result = update(eventBus, defaultFlags().with(Flag.KEEP_GOING), "//pkg:foo");
assertThat(result.hasError()).isTrue();
assertThat(recorder.events)
.contains(
Pair.of(Label.parseAbsolute("//pkg:foo"), Label.parseAbsolute("//nopackage:missing")));
assertContainsEvent("missing value for mandatory attribute 'outs'");
assertContainsEvent("no such package 'nopackage'");
// Skyframe correctly reports the other root cause as the genrule itself (since it is
// missing attributes).
assertThat(recorder.events).hasSize(2);
assertThat(recorder.events)
.contains(Pair.of(Label.parseAbsolute("//pkg:foo"), Label.parseAbsolute("//pkg:foo")));
}
@Test
public void testConvolutedLoadRootCauseAnalysis() throws Exception {
// You need license declarations in third_party. We use this constraint to
// create targets that are loadable, but are in error.
scratch.file("third_party/first/BUILD",
"sh_library(name='first', deps=['//third_party/second'], licenses=['notice'])");
scratch.file("third_party/second/BUILD",
"sh_library(name='second', deps=['//third_party/third'], licenses=['notice'])");
scratch.file("third_party/third/BUILD",
"sh_library(name='third', deps=['//third_party/fourth'], licenses=['notice'])");
scratch.file("third_party/fourth/BUILD",
"sh_library(name='fourth', deps=['//third_party/fifth'])");
scratch.file("third_party/fifth/BUILD",
"sh_library(name='fifth', licenses=['notice'])");
reporter.removeHandler(failFastHandler);
EventBus eventBus = new EventBus();
LoadingFailureRecorder recorder = new LoadingFailureRecorder();
eventBus.register(recorder);
// Note: no need to run analysis for a loading failure.
AnalysisResult result = update(eventBus, defaultFlags().with(Flag.KEEP_GOING),
"//third_party/first", "//third_party/third");
assertThat(result.hasError()).isTrue();
assertThat(recorder.events).hasSize(2);
assertTrue(recorder.events.toString(), recorder.events.contains(
Pair.of(Label.parseAbsolute("//third_party/first"),
Label.parseAbsolute("//third_party/fourth"))));
assertThat(recorder.events)
.contains(Pair.of(
Label.parseAbsolute("//third_party/third"),
Label.parseAbsolute("//third_party/fourth")));
}
@Test
public void testMultipleRootCauseReporting() throws Exception {
scratch.file("gp/BUILD",
"sh_library(name = 'gp', deps = ['//p:p'])");
scratch.file("p/BUILD",
"sh_library(name = 'p', deps = ['//c1:not', '//c2:not'])");
scratch.file("c1/BUILD");
scratch.file("c2/BUILD");
reporter.removeHandler(failFastHandler);
EventBus eventBus = new EventBus();
LoadingFailureRecorder recorder = new LoadingFailureRecorder();
eventBus.register(recorder);
AnalysisResult result = update(eventBus, defaultFlags().with(Flag.KEEP_GOING), "//gp");
assertThat(result.hasError()).isTrue();
assertThat(recorder.events).hasSize(2);
assertTrue(recorder.events.toString(), recorder.events.contains(
Pair.of(Label.parseAbsolute("//gp"),
Label.parseAbsolute("//c1:not"))));
assertThat(recorder.events)
.contains(Pair.of(Label.parseAbsolute("//gp"), Label.parseAbsolute("//c2:not")));
}
/**
* Regression test for: "Package group includes are broken"
*/
@Test
public void testTopLevelPackageGroup() throws Exception {
scratch.file("tropical/BUILD",
"package_group(name='guava', includes=[':mango'])",
"package_group(name='mango')");
// If the analysis phase results in an error, this will throw an exception
update("//tropical:guava");
// Check if the included package group also got analyzed
assertNotNull(getConfiguredTarget("//tropical:mango", null));
}
@Test
public void testTopLevelInputFile() throws Exception {
scratch.file("tropical/BUILD",
"exports_files(['file.txt'])");
update("//tropical:file.txt");
assertNotNull(getConfiguredTarget("//tropical:file.txt", null));
}
@Test
public void topLevelConfigurationHook() throws Exception {
setConfigFragmentsAvailableInTests(TestConfigFragments.FragmentWithTopLevelConfigHook1Factory);
scratch.file(
"package/BUILD",
"sh_binary(name = 'binary', srcs = ['binary.sh'])");
ConfiguredTarget ct = Iterables.getOnlyElement(update("//package:binary").getTargetsToBuild());
BuildConfiguration.Options options =
ct.getConfiguration().getOptions().get(BuildConfiguration.Options.class);
assertThat(options.testArguments).containsExactly("CONFIG HOOK 1");
}
@Test
public void topLevelComposedConfigurationHooks() throws Exception {
setConfigFragmentsAvailableInTests(
TestConfigFragments.FragmentWithTopLevelConfigHook1Factory,
TestConfigFragments.FragmentWithTopLevelConfigHook2Factory);
scratch.file(
"package/BUILD",
"sh_binary(name = 'binary', srcs = ['binary.sh'])");
ConfiguredTarget ct = Iterables.getOnlyElement(update("//package:binary").getTargetsToBuild());
BuildConfiguration.Options options =
ct.getConfiguration().getOptions().get(BuildConfiguration.Options.class);
assertThat(options.testArguments).containsExactly("CONFIG HOOK 1", "CONFIG HOOK 2");
}
@Test
public void testGetDirectPrerequisites() throws Exception {
scratch.file(
"package/BUILD",
"filegroup(name='top', srcs=[':inner', 'file'])",
"sh_binary(name='inner', srcs=['script.sh'])");
update("//package:top");
ConfiguredTarget top = getConfiguredTarget("//package:top", getTargetConfiguration());
Iterable<ConfiguredTarget> targets = getView().getDirectPrerequisitesForTesting(
reporter, top, getBuildConfigurationCollection());
Iterable<Label> labels =
Iterables.transform(
targets,
new Function<ConfiguredTarget, Label>() {
@Override
public Label apply(ConfiguredTarget target) {
return target.getLabel();
}
});
assertThat(labels)
.containsExactly(
Label.parseAbsolute("//package:inner"), Label.parseAbsolute("//package:file"));
}
@Test
public void testGetDirectPrerequisiteDependencies() throws Exception {
scratch.file(
"package/BUILD",
"filegroup(name='top', srcs=[':inner', 'file'])",
"sh_binary(name='inner', srcs=['script.sh'])");
update("//package:top");
ConfiguredTarget top = getConfiguredTarget("//package:top", getTargetConfiguration());
Iterable<Dependency> targets = getView().getDirectPrerequisiteDependenciesForTesting(
reporter, top, getBuildConfigurationCollection()).values();
Dependency innerDependency;
Dependency fileDependency;
if (top.getConfiguration().useDynamicConfigurations()) {
innerDependency =
Dependency.withTransitionAndAspects(
Label.parseAbsolute("//package:inner"),
Attribute.ConfigurationTransition.NONE,
AspectCollection.EMPTY);
} else {
innerDependency =
Dependency.withConfiguration(
Label.parseAbsolute("//package:inner"),
getTargetConfiguration());
}
fileDependency =
Dependency.withNullConfiguration(
Label.parseAbsolute("//package:file"));
assertThat(targets).containsExactly(innerDependency, fileDependency);
}
/**
* Tests that the {@code --output directory name} option cannot be used on
* the command line.
*/
@Test
public void testConfigurationShortName() throws Exception {
// Check that output directory name is still the name, otherwise this test is not testing what
// we expect.
BuildConfiguration.Options options = Options.getDefaults(BuildConfiguration.Options.class);
options.outputDirectoryName = "/home/wonkaw/wonka_chocolate/factory/out";
assertWithMessage("The flag's name may have been changed; this test may need to be updated.")
.that(options.asMap().get("output directory name"))
.isEqualTo("/home/wonkaw/wonka_chocolate/factory/out");
try {
useConfiguration("--output directory name=foo");
fail();
} catch (OptionsParsingException e) {
assertThat(e).hasMessage("Unrecognized option: --output directory name=foo");
}
}
@Test
public void testFileTranslations() throws Exception {
scratch.file("foo/file");
scratch.file("foo/BUILD",
"exports_files(['file'])");
useConfiguration("--message_translations=//foo:file");
scratch.file("bar/BUILD",
"sh_library(name = 'bar')");
update("//bar");
}
// Regression test: "output_filter broken (but in a different way)"
@Test
public void testOutputFilterSeeWarning() throws Exception {
runAnalysisWithOutputFilter(Pattern.compile(".*"));
assertContainsEvent("please do not import '//java/a:A.java'");
}
// Regression test: "output_filter broken (but in a different way)"
@Test
public void testOutputFilter() throws Exception {
runAnalysisWithOutputFilter(Pattern.compile("^//java/c"));
assertNoEvents();
}
@Test
public void testAnalysisErrorMessageWithKeepGoing() throws Exception {
scratch.file("a/BUILD", "sh_binary(name='a', srcs=['a1.sh', 'a2.sh'])");
reporter.removeHandler(failFastHandler);
AnalysisResult result = update(defaultFlags().with(Flag.KEEP_GOING), "//a");
assertThat(result.hasError()).isTrue();
assertContainsEvent("errors encountered while analyzing target '//a:a'");
}
/**
* Regression test: Exception in ConfiguredTargetGraph.checkForCycles()
* when multiple top-level targets depend on the same cycle.
*/
@Test
public void testCircularDependencyBelowTwoTargets() throws Exception {
scratch.file("foo/BUILD",
"sh_library(name = 'top1', srcs = ['top1.sh'], deps = [':rec1'])",
"sh_library(name = 'top2', srcs = ['top2.sh'], deps = [':rec1'])",
"sh_library(name = 'rec1', srcs = ['rec1.sh'], deps = [':rec2'])",
"sh_library(name = 'rec2', srcs = ['rec2.sh'], deps = [':rec1'])"
);
reporter.removeHandler(failFastHandler);
AnalysisResult result =
update(defaultFlags().with(Flag.KEEP_GOING), "//foo:top1", "//foo:top2");
assertThat(result.hasError()).isTrue();
assertContainsEvent("in sh_library rule //foo:rec1: cycle in dependency graph:\n");
assertContainsEvent("in sh_library rule //foo:top");
}
// Regression test: cycle node depends on error.
@Test
public void testErrorBelowCycle() throws Exception {
scratch.file("foo/BUILD",
"sh_library(name = 'top', deps = ['mid'])",
"sh_library(name = 'mid', deps = ['bad', 'cycle1'])",
"sh_library(name = 'bad', srcs = ['//badbuild:isweird'])",
"sh_library(name = 'cycle1', deps = ['cycle2', 'mid'])",
"sh_library(name = 'cycle2', deps = ['cycle1'])");
scratch.file("badbuild/BUILD", "");
reporter.removeHandler(failFastHandler);
injectGraphListenerForTesting(
new Listener() {
@Override
public void accept(SkyKey key, EventType type, Order order, Object context) {}
},
/*deterministic=*/ true);
try {
update("//foo:top");
fail();
} catch (ViewCreationFailedException e) {
// Expected.
}
assertContainsEvent("no such target '//badbuild:isweird': target 'isweird' not declared in "
+ "package 'badbuild'");
assertContainsEvent("and referenced by '//foo:bad'");
assertContainsEvent("in sh_library rule //foo");
assertContainsEvent("cycle in dependency graph");
assertEventCountAtLeast(2, eventCollector);
}
@Test
public void testErrorBelowCycleKeepGoing() throws Exception {
scratch.file("foo/BUILD",
"sh_library(name = 'top', deps = ['mid'])",
"sh_library(name = 'mid', deps = ['bad', 'cycle1'])",
"sh_library(name = 'bad', srcs = ['//badbuild:isweird'])",
"sh_library(name = 'cycle1', deps = ['cycle2', 'mid'])",
"sh_library(name = 'cycle2', deps = ['cycle1'])");
scratch.file("badbuild/BUILD", "");
reporter.removeHandler(failFastHandler);
update(defaultFlags().with(Flag.KEEP_GOING), "//foo:top");
assertContainsEvent("no such target '//badbuild:isweird': target 'isweird' not declared in "
+ "package 'badbuild'");
assertContainsEvent("and referenced by '//foo:bad'");
assertContainsEvent("in sh_library rule //foo");
assertContainsEvent("cycle in dependency graph");
// Dynamic configurations trigger this error both in configuration trimming (which visits
// the transitive target closure) and in the normal configured target cycle detection path.
// So we get an additional instance of this check (which varies depending on whether Skyframe
// loading phase is enabled).
// TODO(gregce): refactor away this variation. Note that the duplicate doesn't make it into
// real user output (it only affects tests).
if (!getTargetConfiguration().useDynamicConfigurations()) {
assertEventCount(3, eventCollector);
}
}
@Test
public void testAnalysisEntryHasActionsEvenWithError() throws Exception {
scratch.file("foo/BUILD",
"cc_binary(name = 'foo', linkshared = 1, srcs = ['foo.cc'])");
reporter.removeHandler(failFastHandler);
try {
update("//foo:foo");
fail(); // Expected ViewCreationFailedException.
} catch (ViewCreationFailedException e) {
// ok.
}
}
@Test
public void testHelpfulErrorForWrongPackageLabels() throws Exception {
reporter.removeHandler(failFastHandler);
scratch.file("x/BUILD",
"cc_library(name='x', srcs=['x.cc'])");
scratch.file("y/BUILD",
"cc_library(name='y', srcs=['y.cc'], deps=['//x:z'])");
AnalysisResult result = update(defaultFlags().with(Flag.KEEP_GOING), "//y:y");
assertThat(result.hasError()).isTrue();
assertContainsEvent("no such target '//x:z': "
+ "target 'z' not declared in package 'x' "
+ "defined by /workspace/x/BUILD and referenced by '//y:y'");
}
@Test
public void testNewActionsAreDifferentAndDontConflict() throws Exception {
scratch.file("pkg/BUILD",
"genrule(name='a', ",
" cmd='',",
" outs=['a.out'])");
update("//pkg:a.out");
OutputFileConfiguredTarget outputCT = (OutputFileConfiguredTarget)
getConfiguredTarget("//pkg:a.out");
Artifact outputArtifact = outputCT.getArtifact();
Action action = getGeneratingAction(outputArtifact);
assertNotNull(action);
scratch.overwriteFile("pkg/BUILD",
"genrule(name='a', ",
" cmd='false',",
" outs=['a.out'])");
update("//pkg:a.out");
assertFalse("Actions should not be compatible",
Actions.canBeShared(action, getGeneratingAction(outputArtifact)));
}
/**
* This test exercises the case where we invalidate (mark dirty) a node in one build command
* invocation and the revalidation (because it did not change) happens in a subsequent build
* command call.
*
* - In the first update call we construct A.
*
* - Then we construct B and we make the glob get invalidated. We do that by deleting a file
* because it depends on the directory listing. Because of that A gets invalidated.
*
* - Then we construct A again. The glob gets revalidated because it is still matching just A.java
* and A configured target gets revalidated too. At the end of the analysis A java action should
* be in the action graph.
*/
@Test
public void testMultiBuildInvalidationRevalidation() throws Exception {
scratch.file("java/a/A.java", "bla1");
scratch.file("java/a/C.java", "bla2");
scratch.file("java/a/BUILD",
"java_test(name = 'A',",
" srcs = glob(['A*.java']))",
"java_test(name = 'B',",
" srcs = ['B.java'])");
update("//java/a:A");
ConfiguredTarget ct = getConfiguredTarget("//java/a:A");
scratch.deleteFile("java/a/C.java");
update("//java/a:B");
update("//java/a:A");
assertNotNull(getGeneratingAction(
getBinArtifact("A_deploy.jar", ct)));
}
/**
* Regression test: ClassCastException in SkyframeLabelVisitor.updateRootCauses.
*/
@Test
public void testDepOnGoodTargetInBadPkgAndTransitivelyBadTarget() throws Exception {
reporter.removeHandler(failFastHandler);
scratch.file("parent/BUILD",
"sh_library(name = 'foo',",
" srcs = ['//badpkg1:okay-target', '//okaypkg:transitively-bad-target'])");
Path badpkg1BuildFile = scratch.file("badpkg1/BUILD",
"exports_files(['okay-target'])",
"invalidbuildsyntax");
scratch.file("okaypkg/BUILD",
"sh_library(name = 'transitively-bad-target',",
" srcs = ['//badpkg2:bad-target'])");
Path badpkg2BuildFile = scratch.file("badpkg2/BUILD",
"sh_library(name = 'bad-target')",
"invalidbuildsyntax");
update(defaultFlags().with(Flag.KEEP_GOING), "//parent:foo");
assertEquals(1, getFrequencyOfErrorsWithLocation(
badpkg1BuildFile.asFragment(), eventCollector));
assertEquals(1, getFrequencyOfErrorsWithLocation(
badpkg2BuildFile.asFragment(), eventCollector));
}
@Test
public void testDepOnGoodTargetInBadPkgAndTransitiveCycle_NotIncremental() throws Exception {
runTestDepOnGoodTargetInBadPkgAndTransitiveCycle(/*incremental=*/false);
}
@Test
public void testDepOnGoodTargetInBadPkgAndTransitiveCycle_Incremental() throws Exception {
runTestDepOnGoodTargetInBadPkgAndTransitiveCycle(/*incremental=*/true);
}
/**
* Regression test: in keep_going mode, cycles in target graph aren't reported
* if package is in error.
*/
@Test
public void testCycleReporting_TargetCycleWhenPackageInError() throws Exception {
reporter.removeHandler(failFastHandler);
scratch.file("cycles/BUILD",
"sh_library(name = 'a', deps = [':b'])",
"sh_library(name = 'b', deps = [':a'])",
"notvalidbuildsyntax");
update(defaultFlags().with(Flag.KEEP_GOING), "//cycles:a");
assertContainsEvent("'notvalidbuildsyntax'");
assertContainsEvent("cycle in dependency graph");
}
@Test
public void testTransitiveLoadingDoesntShortCircuitInKeepGoing() throws Exception {
reporter.removeHandler(failFastHandler);
scratch.file("parent/BUILD",
"sh_library(name = 'a', deps = ['//child:b'])",
"parentisbad");
scratch.file("child/BUILD",
"sh_library(name = 'b')",
"childisbad");
update(defaultFlags().with(Flag.KEEP_GOING), "//parent:a");
assertContainsEventWithFrequency("parentisbad", 1);
assertContainsEventWithFrequency("childisbad", 1);
assertContainsEventWithFrequency("and referenced by '//parent:a'", 1);
}
/**
* Smoke test for the Skyframe code path.
*/
@Test
public void testSkyframe() throws Exception {
setupDummyRule();
String aoutLabel = "//pkg:a.out";
update(aoutLabel);
// However, a ConfiguredTarget was actually produced.
ConfiguredTarget target = Iterables.getOnlyElement(getAnalysisResult().getTargetsToBuild());
assertEquals(aoutLabel, target.getLabel().toString());
Artifact aout = Iterables.getOnlyElement(
target.getProvider(FileProvider.class).getFilesToBuild());
Action action = getGeneratingAction(aout);
assertSame(FailAction.class, action.getClass());
}
/**
* ConfiguredTargetFunction should not register actions in legacy Blaze ActionGraph unless
* the creation of the node is successful.
*/
@Test
public void testActionsNotRegisteredInLegacyWhenError() throws Exception {
// First find the artifact we want to make sure is not generated by an action with an error.
// Then update the BUILD file and re-analyze.
scratch.file("actions_not_registered/BUILD",
"cc_binary(name = 'foo', srcs = ['foo.cc'])");
update("//actions_not_registered:foo");
Artifact fooOut = Iterables.getOnlyElement(
getConfiguredTarget("//actions_not_registered:foo")
.getProvider(FileProvider.class).getFilesToBuild());
assertNotNull(getActionGraph().getGeneratingAction(fooOut));
clearAnalysisResult();
scratch.overwriteFile("actions_not_registered/BUILD",
"cc_binary(name = 'foo', linkshared = 1, srcs = ['foo.cc'])");
reporter.removeHandler(failFastHandler);
try {
update("//actions_not_registered:foo");
fail("This build should fail because: 'linkshared' used in non-shared library");
} catch (ViewCreationFailedException e) {
assertNull(getActionGraph().getGeneratingAction(fooOut));
}
}
/**
* Regression test:
* "skyframe: ArtifactFactory and ConfiguredTargets out of sync".
*/
@Test
public void testSkyframeAnalyzeRuleThenItsOutputFile() throws Exception {
scratch.file("pkg/BUILD",
"testing_dummy_rule(name='foo', ",
" srcs=['a.src'],",
" outs=['a.out'])");
scratch.file("pkg2/BUILD",
"testing_dummy_rule(name='foo', ",
" srcs=['a.src'],",
" outs=['a.out'])");
String aoutLabel = "//pkg:a.out";
update("//pkg2:foo");
update("//pkg:foo");
scratch.overwriteFile("pkg2/BUILD",
"testing_dummy_rule(name='foo', ",
" srcs=['a.src'],",
" outs=['a.out'])",
"# Comment");
update("//pkg:a.out");
// However, a ConfiguredTarget was actually produced.
ConfiguredTarget target = Iterables.getOnlyElement(getAnalysisResult().getTargetsToBuild());
assertEquals(aoutLabel, target.getLabel().toString());
Artifact aout = Iterables.getOnlyElement(
target.getProvider(FileProvider.class).getFilesToBuild());
Action action = getGeneratingAction(aout);
assertSame(FailAction.class, action.getClass());
}
/**
* Tests that skyframe reports the root cause as being the target that depended on the symlink
* cycle.
*/
@Test
public void testRootCauseReportingFileSymlinks() throws Exception {
scratch.file("gp/BUILD",
"sh_library(name = 'gp', deps = ['//p'])");
scratch.file("p/BUILD",
"sh_library(name = 'p', deps = ['//c'])");
scratch.file("c/BUILD",
"sh_library(name = 'c', deps = [':c1', ':c2'])",
"sh_library(name = 'c1', deps = ['//cycles1'])",
"sh_library(name = 'c2', deps = ['//cycles2'])");
Path cycles1BuildFilePath = scratch.file("cycles1/BUILD",
"sh_library(name = 'cycles1', srcs = glob(['*.sh']))");
Path cycles2BuildFilePath = scratch.file("cycles2/BUILD",
"sh_library(name = 'cycles2', srcs = glob(['*.sh']))");
cycles1BuildFilePath.getParentDirectory().getRelative("cycles1.sh").createSymbolicLink(
PathFragment.create("cycles1.sh"));
cycles2BuildFilePath.getParentDirectory().getRelative("cycles2.sh").createSymbolicLink(
PathFragment.create("cycles2.sh"));
reporter.removeHandler(failFastHandler);
EventBus eventBus = new EventBus();
LoadingFailureRecorder recorder = new LoadingFailureRecorder();
eventBus.register(recorder);
AnalysisResult result = update(eventBus, defaultFlags().with(Flag.KEEP_GOING), "//gp");
assertThat(result.hasError()).isTrue();
assertThat(recorder.events).hasSize(2);
assertTrue(recorder.events.toString(), recorder.events.contains(
Pair.of(Label.parseAbsolute("//gp"), Label.parseAbsolute("//cycles1"))));
assertTrue(recorder.events.toString(), recorder.events.contains(
Pair.of(Label.parseAbsolute("//gp"), Label.parseAbsolute("//cycles2"))));
}
/**
* Regression test for bug when a configured target has missing deps, but also depends
* transitively on an error. We build //foo:query, which depends on a valid and an invalid target
* pattern. We ensure that by the time it requests its dependent target patterns, the invalid one
* is ready, and throws (though not before the request is registered). Then, when bubbling the
* invalid target pattern error up, we ensure that it bubbles into //foo:query, which must cope
* with the combination of an error and a missing dep.
*/
@Test
public void testGenQueryWithBadTargetAndUnfinishedTarget() throws Exception {
// The target //foo:zquery is used to force evaluation of //foo:nosuchtarget before the target
// patterns in //foo:query are enqueued for evaluation. That way, //foo:query will depend on one
// invalid target pattern and two target patterns that haven't been evaluated yet.
// It is important that 'query' come before 'zquery' alphabetically, so that when the error is
// bubbling up, it goes to the //foo:query node -- we use a graph implementation in which the
// reverse deps of each entry are ordered alphabetically. It is also important that a missing
// target pattern is requested before the exception is thrown, so we have both //foo:b and
// //foo:z missing from the deps, in the hopes that at least one of them will come before
// //foo:nosuchtarget.
scratch.file("foo/BUILD",
"genquery(name = 'query',",
" expression = 'deps(//foo:b) except //foo:nosuchtarget except //foo:z',",
" scope = ['//foo:a'])",
"genquery(name = 'zquery',",
" expression = 'deps(//foo:nosuchtarget)',",
" scope = ['//foo:a'])",
"sh_library(name = 'a')",
"sh_library(name = 'b')",
"sh_library(name = 'z')"
);
Listener listener =
new Listener() {
private final CountDownLatch errorDone = new CountDownLatch(1);
private final CountDownLatch realQueryStarted = new CountDownLatch(1);
@Override
public void accept(SkyKey key, EventType type, Order order, Object context) {
if (!key.functionName().equals(SkyFunctions.TARGET_PATTERN)) {
return;
}
String label = ((TargetPatternKey) key.argument()).getPattern();
if (label.equals("//foo:nosuchtarget")) {
if (type == EventType.SET_VALUE) {
// Inform //foo:query-dep-registering thread that it may proceed.
errorDone.countDown();
// Wait to make sure //foo:query-dep-registering process has started.
TrackingAwaiter.INSTANCE.awaitLatchAndTrackExceptions(
realQueryStarted, "//foo:query did not request dep in time");
} else if (type == EventType.ADD_REVERSE_DEP
&& context.toString().contains("foo:query")) {
// Make sure that when foo:query requests foo:nosuchtarget, it's already done.
TrackingAwaiter.INSTANCE.awaitLatchAndTrackExceptions(
errorDone, "//foo:nosuchtarget did not evaluate in time");
}
} else if ((label.equals("//foo:b") || label.equals("//foo:z"))
&& type == EventType.CREATE_IF_ABSENT) {
// Inform error-evaluating thread that it may throw an exception.
realQueryStarted.countDown();
TrackingAwaiter.INSTANCE.awaitLatchAndTrackExceptions(
errorDone, "//foo:nosuchtarget did not evaluate in time");
// Don't let the target pattern //foo:{b,z} get enqueued for evaluation until we
// receive an interrupt signal from the threadpool. The interrupt means that
// evaluation is shutting down, and so //foo:{b,z} definitely won't get evaluated.
CountDownLatch waitForInterrupt = new CountDownLatch(1);
try {
waitForInterrupt.await(TestUtils.WAIT_TIMEOUT_SECONDS, TimeUnit.SECONDS);
throw new IllegalStateException("node was not interrupted in time");
} catch (InterruptedException e) {
// Expected.
Thread.currentThread().interrupt();
}
}
}
};
injectGraphListenerForTesting(listener, /*deterministic=*/ true);
reporter.removeHandler(failFastHandler);
try {
update("//foo:query", "//foo:zquery");
fail();
} catch (ViewCreationFailedException e) {
Truth.assertThat(e.getMessage())
.contains("Analysis of target '//foo:query' failed; build aborted");
}
TrackingAwaiter.INSTANCE.assertNoErrors();
}
/**
* Tests that rules with configurable attributes can be accessed through {@link
* com.google.devtools.build.lib.skyframe.PostConfiguredTargetFunction}.
* This is a regression test for a Bazel crash.
*/
@Test
public void testPostProcessedConfigurableAttributes() throws Exception {
useConfiguration("--cpu=k8");
reporter.removeHandler(failFastHandler); // Expect errors from action conflicts.
scratch.file("conflict/BUILD",
"config_setting(name = 'a', values = {'test_arg': 'a'})",
"cc_library(name='x', srcs=select({':a': ['a.cc'], '//conditions:default': ['foo.cc']}))",
"cc_binary(name='_objs/x/conflict/foo.pic.o', srcs=['bar.cc'])");
AnalysisResult result = update(
defaultFlags().with(Flag.KEEP_GOING),
"//conflict:_objs/x/conflict/foo.pic.o",
"//conflict:x");
assertThat(result.hasError()).isTrue();
// Expect to reach this line without a Precondition-triggered NullPointerException.
assertContainsEvent(
"file 'conflict/_objs/x/conflict/foo.pic.o' is generated by these conflicting actions");
}
@Test
public void testCycleDueToJavaLauncherConfiguration() throws Exception {
if (defaultFlags().contains(Flag.DYNAMIC_CONFIGURATIONS)) {
// Dynamic configurations don't yet support late-bound attributes. Development testing already
// runs all tests with dynamic configurations enabled, so this will still fail for developers
// and won't get lost in the fog.
return;
}
scratch.file("foo/BUILD",
"java_binary(name = 'java', srcs = ['DoesntMatter.java'])",
"cc_binary(name = 'cpp', data = [':java'])");
// Everything is fine - the dependency graph is acyclic.
update("//foo:java", "//foo:cpp");
if (getTargetConfiguration().trimConfigurations()) {
fail(ExpectedDynamicConfigurationErrors.LATE_BOUND_ATTRIBUTES_UNSUPPORTED);
}
// Now there will be an analysis-phase cycle because the java_binary now has an implicit dep on
// the cc_binary launcher.
useConfiguration("--java_launcher=//foo:cpp");
reporter.removeHandler(failFastHandler);
try {
update("//foo:java", "//foo:cpp");
fail();
} catch (ViewCreationFailedException expected) {
Truth.assertThat(expected.getMessage())
.matches("Analysis of target '//foo:(java|cpp)' failed; build aborted.*");
}
assertContainsEvent("cycle in dependency graph");
}
@Test
public void testDependsOnBrokenTarget() throws Exception {
scratch.file("foo/BUILD",
"sh_test(name = 'test', srcs = ['test.sh'], data = ['//bar:data'])");
scratch.file("bar/BUILD",
"BROKEN BROKEN BROKEN!!!");
reporter.removeHandler(failFastHandler);
try {
update("//foo:test");
fail();
} catch (ViewCreationFailedException expected) {
Truth.assertThat(expected.getMessage())
.matches("Analysis of target '//foo:test' failed; build aborted.*");
}
}
/**
* Regression test: IllegalStateException in BuildView.update() on circular dependency instead of
* graceful failure.
*/
@Test
public void testCircularDependency() throws Exception {
scratch.file("cycle/BUILD",
"cc_library(name = 'foo', srcs = ['foo.cc'], deps = [':bar'])",
"cc_library(name = 'bar', srcs = ['bar.cc'], deps = [':foo'])");
reporter.removeHandler(failFastHandler);
try {
update("//cycle:foo");
fail();
} catch (ViewCreationFailedException expected) {
assertContainsEvent("in cc_library rule //cycle:foo: cycle in dependency graph:");
assertThat(expected.getMessage())
.contains("Analysis of target '//cycle:foo' failed; build aborted");
}
}
/**
* Regression test: IllegalStateException in BuildView.update() on circular dependency instead of
* graceful failure.
*/
@Test
public void testCircularDependencyWithKeepGoing() throws Exception {
scratch.file("cycle/BUILD",
"cc_library(name = 'foo', srcs = ['foo.cc'], deps = [':bar'])",
"cc_library(name = 'bar', srcs = ['bar.cc'], deps = [':foo'])",
"cc_library(name = 'bat', srcs = ['bat.cc'], deps = [':bas'])",
"cc_library(name = 'bas', srcs = ['bas.cc'], deps = [':bau'])",
"cc_library(name = 'bau', srcs = ['bas.cc'], deps = [':bas'])",
"cc_library(name = 'baz', srcs = ['baz.cc'])");
reporter.removeHandler(failFastHandler);
EventBus eventBus = new EventBus();
LoadingFailureRecorder loadingFailureRecorder = new LoadingFailureRecorder();
AnalysisFailureRecorder analysisFailureRecorder = new AnalysisFailureRecorder();
eventBus.register(loadingFailureRecorder);
eventBus.register(analysisFailureRecorder);
update(eventBus, defaultFlags().with(Flag.KEEP_GOING),
"//cycle:foo", "//cycle:bat", "//cycle:baz");
assertContainsEvent("in cc_library rule //cycle:foo: cycle in dependency graph:");
assertContainsEvent("in cc_library rule //cycle:bas: cycle in dependency graph:");
assertContainsEvent(
"errors encountered while analyzing target '//cycle:foo': it will not be built");
assertContainsEvent(
"errors encountered while analyzing target '//cycle:bat': it will not be built");
// With interleaved loading and analysis, we can no longer distinguish loading-phase cycles
// and analysis-phase cycles. This was previously reported as a loading-phase cycle, as it
// happens with any configuration (cycle is hard-coded in the BUILD files). Also see the
// test below.
assertThat(Iterables.transform(analysisFailureRecorder.events, ANALYSIS_EVENT_TO_STRING_PAIR))
.containsExactly(
Pair.of("//cycle:foo", "//cycle:foo"), Pair.of("//cycle:bat", "//cycle:bas"));
}
@Test
public void testCircularDependencyWithLateBoundLabel() throws Exception {
scratch.file("cycle/BUILD",
"cc_library(name = 'foo', deps = [':bar'])",
"cc_library(name = 'bar')");
useConfiguration("--experimental_stl=//cycle:foo");
reporter.removeHandler(failFastHandler);
EventBus eventBus = new EventBus();
LoadingFailureRecorder loadingFailureRecorder = new LoadingFailureRecorder();
AnalysisFailureRecorder analysisFailureRecorder = new AnalysisFailureRecorder();
eventBus.register(loadingFailureRecorder);
eventBus.register(analysisFailureRecorder);
AnalysisResult result = update(eventBus, defaultFlags().with(Flag.KEEP_GOING), "//cycle:foo");
assertThat(result.hasError()).isTrue();
assertContainsEvent("in cc_library rule //cycle:foo: cycle in dependency graph:");
// This needs to be reported as an anlysis-phase cycle; the cycle only occurs due to the stl
// command-line option, which is part of the configuration, and which is used due to the
// late-bound label.
assertThat(Iterables.transform(analysisFailureRecorder.events, ANALYSIS_EVENT_TO_STRING_PAIR))
.containsExactly(Pair.of("//cycle:foo", "//cycle:foo"));
assertThat(loadingFailureRecorder.events).isEmpty();
}
@Test
public void testLoadingErrorReportedCorrectly() throws Exception {
scratch.file("a/BUILD", "cc_library(name='a')");
scratch.file("b/BUILD", "cc_library(name='b', deps = ['//missing:lib'])");
reporter.removeHandler(failFastHandler);
AnalysisResult result = update(defaultFlags().with(Flag.KEEP_GOING), "//a", "//b");
assertThat(result.hasError()).isTrue();
assertThat(result.getError())
.contains("command succeeded, but there were loading phase errors");
}
@Test
public void testBadLabelInConfiguration() throws Exception {
useConfiguration("--crosstool_top=//third_party/crosstool/v2");
reporter.removeHandler(failFastHandler);
try {
update(defaultFlags().with(Flag.KEEP_GOING));
fail();
} catch (InvalidConfigurationException e) {
assertThat(e.getMessage()).contains("third_party/crosstool/v2");
}
}
@Test
public void testMissingFdoOptimize() throws Exception {
// The fdo_optimize flag uses a different code path, because it also accepts paths.
useConfiguration("--fdo_optimize=//does/not/exist");
reporter.removeHandler(failFastHandler);
try {
update(defaultFlags().with(Flag.KEEP_GOING));
fail();
} catch (InvalidConfigurationException e) {
assertContainsEvent(
"no such package 'does/not/exist': BUILD file not found on package path");
}
}
@Test
public void testMissingJavabase() throws Exception {
// The javabase flag uses yet another code path with its own redirection logic on top of the
// redirect chaser.
scratch.file("jdk/BUILD",
"filegroup(name = 'jdk', srcs = [",
" '//does/not/exist:a-piii', '//does/not/exist:b-k8', '//does/not/exist:c-default'])");
scratch.file("does/not/exist/BUILD");
useConfigurationFactory(AnalysisMock.get().createConfigurationFactory());
useConfiguration("--javabase=//jdk");
reporter.removeHandler(failFastHandler);
try {
update(defaultFlags().with(Flag.KEEP_GOING));
fail();
} catch (InvalidConfigurationException e) {
// Expected
}
}
@Test
public void testMissingXcodeVersion() throws Exception {
// The xcode_version flag uses yet another code path on top of the redirect chaser.
// Note that the redirect chaser throws if it can't find a package, but doesn't throw if it
// can't find a label in a package - that's why we use an empty package here.
scratch.file("xcode/BUILD");
useConfiguration("--xcode_version=1.2", "--xcode_version_config=//xcode:does_not_exist");
reporter.removeHandler(failFastHandler);
try {
update(defaultFlags().with(Flag.KEEP_GOING));
fail();
} catch (InvalidConfigurationException e) {
assertThat(e.getMessage()).contains("//xcode:does_not_exist");
}
}
@Test
public void testVisibilityReferencesNonexistentPackage() throws Exception {
scratch.file("z/a/BUILD",
"py_library(name='a', visibility=['//nonexistent:nothing'])");
scratch.file("z/b/BUILD",
"py_library(name='b', deps=['//z/a:a'])");
reporter.removeHandler(failFastHandler);
try {
update("//z/b:b");
fail();
} catch (ViewCreationFailedException expected) {
assertContainsEvent("no such package 'nonexistent'");
}
}
// regression test ("java.lang.IllegalStateException: cannot happen")
@Test
public void testDefaultVisibilityInNonexistentPackage() throws Exception {
scratch.file("z/a/BUILD",
"package(default_visibility=['//b'])",
"py_library(name='alib')");
scratch.file("z/b/BUILD",
"py_library(name='b', deps=['//z/a:alib'])");
reporter.removeHandler(failFastHandler);
try {
update("//z/b:b");
fail();
} catch (ViewCreationFailedException expected) {
assertContainsEvent("no such package 'b'");
}
}
@Test
public void testNonTopLevelErrorsPrintedExactlyOnce() throws Exception {
scratch.file("parent/BUILD",
"sh_library(name = 'a', deps = ['//child:b'])");
scratch.file("child/BUILD",
"sh_library(name = 'b')",
"undefined_symbol");
reporter.removeHandler(failFastHandler);
try {
update("//parent:a");
fail();
} catch (ViewCreationFailedException expected) {
}
assertContainsEventWithFrequency("name 'undefined_symbol' is not defined", 1);
assertContainsEventWithFrequency(
"Target '//child:b' contains an error and its package is in error and referenced "
+ "by '//parent:a'", 1);
}
@Test
public void testNonTopLevelErrorsPrintedExactlyOnce_KeepGoing() throws Exception {
scratch.file("parent/BUILD",
"sh_library(name = 'a', deps = ['//child:b'])");
scratch.file("child/BUILD",
"sh_library(name = 'b')",
"undefined_symbol");
reporter.removeHandler(failFastHandler);
update(defaultFlags().with(Flag.KEEP_GOING), "//parent:a");
assertContainsEventWithFrequency("name 'undefined_symbol' is not defined", 1);
assertContainsEventWithFrequency(
"Target '//child:b' contains an error and its package is in error and referenced "
+ "by '//parent:a'", 1);
}
@Test
public void testNonTopLevelErrorsPrintedExactlyOnce_ActionListener() throws Exception {
scratch.file("parent/BUILD",
"sh_library(name = 'a', deps = ['//child:b'])");
scratch.file("child/BUILD",
"sh_library(name = 'b')",
"undefined_symbol");
scratch.file("okay/BUILD",
"sh_binary(name = 'okay', srcs = ['okay.sh'])");
useConfiguration("--experimental_action_listener=//parent:a");
reporter.removeHandler(failFastHandler);
try {
update("//okay");
fail();
} catch (ViewCreationFailedException e) {
// Expected.
}
assertContainsEventWithFrequency("name 'undefined_symbol' is not defined", 1);
assertContainsEventWithFrequency(
"Target '//child:b' contains an error and its package is in error and referenced "
+ "by '//parent:a'", 1);
}
@Test
public void testNonTopLevelErrorsPrintedExactlyOnce_ActionListener_KeepGoing() throws Exception {
scratch.file("parent/BUILD",
"sh_library(name = 'a', deps = ['//child:b'])");
scratch.file("child/BUILD",
"sh_library(name = 'b')",
"undefined_symbol");
scratch.file("okay/BUILD",
"sh_binary(name = 'okay', srcs = ['okay.sh'])");
useConfiguration("--experimental_action_listener=//parent:a");
reporter.removeHandler(failFastHandler);
update(defaultFlags().with(Flag.KEEP_GOING), "//okay");
assertContainsEventWithFrequency("name 'undefined_symbol' is not defined", 1);
assertContainsEventWithFrequency(
"Target '//child:b' contains an error and its package is in error and referenced "
+ "by '//parent:a'", 1);
}
@Test
public void testTopLevelTargetsAreTrimmedWithDynamicConfigurations() throws Exception {
scratch.file("foo/BUILD",
"sh_library(name='x', ",
" srcs=['x.sh'])");
useConfiguration("--experimental_dynamic_configs=on");
AnalysisResult res = update("//foo:x");
ConfiguredTarget topLevelTarget = Iterables.getOnlyElement(res.getTargetsToBuild());
assertThat(topLevelTarget.getConfiguration().getAllFragments().keySet()).containsExactly(
ruleClassProvider.getUniversalFragment());
}
@Test
public void errorOnMissingDepFragments() throws Exception {
scratch.file("foo/BUILD",
"cc_library(",
" name = 'ccbin', ",
" srcs = ['c.cc'],",
" data = [':javalib'])",
"java_library(",
" name = 'javalib',",
" srcs = ['javalib.java'])");
useConfiguration("--experimental_dynamic_configs=on", "--experimental_disable_jvm");
reporter.removeHandler(failFastHandler);
try {
update("//foo:ccbin");
fail();
} catch (ViewCreationFailedException e) {
// Expected.
}
assertContainsEvent("//foo:ccbin: dependency //foo:javalib from attribute \"data\" is missing "
+ "required config fragments: Jvm");
}
/**
* Here, injecting_rule injects an aspect which acts on a action_rule() and registers an action.
* The action_rule() registers another action of its own.
*
* <p>This test asserts that both actions are reported.
*/
@Test
public void ruleExtraActionsDontHideAspectExtraActions() throws Exception {
useConfiguration("--experimental_action_listener=//pkg:listener");
scratch.file(
"x/BUILD",
"load(':extension.bzl', 'injecting_rule', 'action_rule')",
"injecting_rule(name='a', deps=[':b'])",
"action_rule(name='b')");
scratch.file(
"x/extension.bzl",
"def _aspect1_impl(target, ctx):",
" ctx.empty_action(mnemonic='Mnemonic')",
" return struct()",
"aspect1 = aspect(_aspect1_impl, attr_aspects=['deps'])",
"",
"def _injecting_rule_impl(ctx):",
" return struct()",
"injecting_rule = rule(_injecting_rule_impl, ",
" attrs = { 'deps' : attr.label_list(aspects = [aspect1]) })",
"",
"def _action_rule_impl(ctx):",
" out = ctx.new_file(ctx.label.name)",
" ctx.action(outputs = [out], command = 'dontcare', mnemonic='Mnemonic')",
" return struct()",
"action_rule = rule(_action_rule_impl, attrs = { 'deps' : attr.label_list() })");
scratch.file(
"pkg/BUILD",
"extra_action(name='xa', cmd='echo dont-care')",
"action_listener(name='listener', mnemonics=['Mnemonic'], extra_actions=[':xa'])");
BuildView.AnalysisResult analysisResult = update("//x:a");
List<String> owners = new ArrayList<>();
for (Artifact artifact : analysisResult.getAdditionalArtifactsToBuild()) {
if ("xa".equals(artifact.getExtension())) {
owners.add(artifact.getOwnerLabel().toString());
}
}
assertThat(owners).containsExactly("//x:b", "//x:b");
}
@Test
public void testErrorMessageForMissingPackageGroup() throws Exception {
scratch.file(
"apple/BUILD",
"py_library(name='apple', visibility=['//non:existent'])");
reporter.removeHandler(failFastHandler);
try {
update("//apple");
fail();
} catch (ViewCreationFailedException e) {
// Expected.
}
assertDoesNotContainEvent("implicitly depends upon");
}
/** Runs the same test with the reduced loading phase. */
@TestSpec(size = Suite.SMALL_TESTS)
@RunWith(JUnit4.class)
public static class WithSkyframeLoadingPhase extends BuildViewTest {
@Override
protected FlagBuilder defaultFlags() {
return super.defaultFlags().with(Flag.SKYFRAME_LOADING_PHASE);
}
}
/** Runs the same test with dynamic configurations. */
@TestSpec(size = Suite.SMALL_TESTS)
@RunWith(JUnit4.class)
public static class WithDynamicConfigurations extends BuildViewTest {
@Override
protected FlagBuilder defaultFlags() {
return super.defaultFlags().with(Flag.DYNAMIC_CONFIGURATIONS);
}
}
}