/* * Copyright (c) 2005-2011 Grameen Foundation USA * All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or * implied. See the License for the specific language governing * permissions and limitations under the License. * * See also http://www.apache.org/licenses/LICENSE-2.0.html for an * explanation of the license and how it is applied. */ package org.mifos.accounts.loan.business; import static org.hamcrest.CoreMatchers.is; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertThat; import static org.junit.Assert.assertTrue; import static org.mifos.framework.util.helpers.IntegrationTestObjectMother.sampleBranchOffice; import static org.mifos.framework.util.helpers.IntegrationTestObjectMother.testUser; import java.math.BigDecimal; import java.sql.Date; import java.util.ArrayList; import java.util.List; import java.util.Set; import org.joda.time.DateTime; import org.joda.time.LocalDate; import org.junit.After; import org.junit.AfterClass; import org.junit.Before; import org.junit.Ignore; import org.junit.Test; import org.mifos.accounts.business.AccountActionDateEntity; import org.mifos.accounts.business.AccountFeesActionDetailEntity; import org.mifos.accounts.business.AccountStateEntity; import org.mifos.accounts.exceptions.AccountException; import org.mifos.accounts.fees.business.AmountFeeBO; import org.mifos.accounts.persistence.LegacyAccountDao; import org.mifos.accounts.productdefinition.business.LoanOfferingBO; import org.mifos.accounts.util.helpers.AccountState; import org.mifos.accounts.util.helpers.PaymentData; import org.mifos.application.meeting.business.MeetingBO; import org.mifos.builders.MifosUserBuilder; import org.mifos.clientportfolio.loan.service.RecurringSchedule; import org.mifos.clientportfolio.newloan.applicationservice.CreateLoanAccount; import org.mifos.customers.center.business.CenterBO; import org.mifos.customers.client.business.ClientBO; import org.mifos.customers.group.business.GroupBO; import org.mifos.customers.personnel.business.PersonnelBO; import org.mifos.domain.builders.CenterBuilder; import org.mifos.domain.builders.ClientBuilder; import org.mifos.domain.builders.FeeBuilder; import org.mifos.domain.builders.GroupBuilder; import org.mifos.domain.builders.LoanProductBuilder; import org.mifos.domain.builders.MeetingBuilder; import org.mifos.dto.domain.AccountPaymentDto; import org.mifos.dto.domain.CreateAccountFeeDto; import org.mifos.dto.domain.CreateAccountPenaltyDto; import org.mifos.framework.MifosIntegrationTestCase; import org.mifos.framework.TestUtils; import org.mifos.framework.hibernate.helper.StaticHibernateUtil; import org.mifos.framework.util.DateTimeService; import org.mifos.framework.util.helpers.IntegrationTestObjectMother; import org.mifos.framework.util.helpers.Money; import org.mifos.security.MifosUser; import org.mifos.test.framework.util.DatabaseCleaner; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.security.authentication.TestingAuthenticationToken; import org.springframework.security.core.Authentication; import org.springframework.security.core.context.SecurityContext; import org.springframework.security.core.context.SecurityContextHolder; import org.springframework.security.core.context.SecurityContextImpl; public class LoanAdjustmentsIntegrationTest extends MifosIntegrationTestCase { @Autowired private DatabaseCleaner databaseCleaner; private CenterBO center; private GroupBO group; private ClientBO client; private LoanBO loan; @Autowired private LegacyAccountDao legacyAccountDao; @AfterClass public static void resetCurrency() { new DateTimeService().resetToCurrentSystemDateTime(); } @After public void cleanDatabaseTablesAfterTest() { // NOTE: - only added to stop older integration tests failing due to brittleness databaseCleaner.clean(); } @Before public void cleanDatabaseTables() throws Exception { databaseCleaner.clean(); SecurityContext securityContext = new SecurityContextImpl(); MifosUser principal = new MifosUserBuilder().nonLoanOfficer().withAdminRole().build(); Authentication authentication = new TestingAuthenticationToken(principal, principal); securityContext.setAuthentication(authentication); SecurityContextHolder.setContext(securityContext); } /** * not sure why this is failing now. */ @Ignore @Test public void testWhenALoanIsRepaidEarlyAndThenAdjustedThatTheLoanSummaryAndSchedulesDetailsAreTheSameBeforeAndAfter() throws Exception { // relates to mifos-1986 new DateTimeService().setCurrentDateTimeFixed(date(2010, 10, 13)); loan = createLoan(); Money initialOriginalPrincipal = loan.getLoanSummary().getOriginalPrincipal(); Money initialOriginalInterest = loan.getLoanSummary().getOriginalInterest(); Money initialOriginalFees = loan.getLoanSummary().getOriginalFees(); Money initialPrincipalPaid = loan.getLoanSummary().getPrincipalPaid(); Money initialInterestPaid = loan.getLoanSummary().getInterestPaid(); Money initialFeesPaid = loan.getLoanSummary().getFeesPaid(); // pay 3 installments makePayment(loan, "333.0"); StaticHibernateUtil.flushAndClearSession(); loan = (LoanBO) legacyAccountDao.getAccount(loan.getAccountId()); loan.updateDetails(TestUtils.makeUserWithLocales()); assertThat(loan.getLoanSummary().getOriginalPrincipal(), is(initialOriginalPrincipal)); assertThat(loan.getLoanSummary().getOriginalInterest(), is(initialOriginalInterest)); assertThat(loan.getLoanSummary().getOriginalFees(), is(initialOriginalFees)); assertFalse(loan.getLoanSummary().getPrincipalPaid().equals(initialPrincipalPaid)); assertFalse(loan.getLoanSummary().getInterestPaid().equals(initialInterestPaid)); assertFalse(loan.getLoanSummary().getFeesPaid().equals(initialFeesPaid)); List<LoanInstallment> copySchedule = copyLoanSchedule(loan); makeEarlyPayment(loan); StaticHibernateUtil.flushAndClearSession(); loan = (LoanBO) legacyAccountDao.getAccount(loan.getAccountId()); loan.updateDetails(TestUtils.makeUserWithLocales()); // The early repayment should have caused the original interest and fees to be changed to equal the amounts // paid. assertThat(loan.getLoanSummary().getOriginalPrincipal(), is(initialOriginalPrincipal)); assertFalse(loan.getLoanSummary().getOriginalInterest().equals(initialOriginalInterest)); assertFalse(loan.getLoanSummary().getOriginalFees().equals(initialOriginalFees)); assertThat(loan.getLoanSummary().getPrincipalPaid(), is(loan.getLoanSummary().getOriginalPrincipal())); assertThat(loan.getLoanSummary().getInterestPaid(), is(loan.getLoanSummary().getOriginalInterest())); assertThat(loan.getLoanSummary().getFeesPaid(), is(loan.getLoanSummary().getOriginalFees())); assertFalse(sameSchedule(copySchedule, loan.getAccountActionDates())); adjustLastLoanPayment(loan); StaticHibernateUtil.flushAndClearSession(); loan = (LoanBO) legacyAccountDao.getAccount(loan.getAccountId()); loan.updateDetails(TestUtils.makeUserWithLocales()); // The adjustment of a completed loan should have caused the original amounts to be reset assertThat(loan.getLoanSummary().getOriginalPrincipal(), is(initialOriginalPrincipal)); assertThat(loan.getLoanSummary().getOriginalInterest(), is(initialOriginalInterest)); assertThat(loan.getLoanSummary().getOriginalFees(), is(initialOriginalFees)); assertTrue(sameSchedule(copySchedule, loan.getAccountActionDates())); } @Test public void testWhenACompletedLoanIsAdjustedThatAnAccountStatusChangeHistoryEntryisCreated() throws Exception { // relates to mifos-3479 new DateTimeService().setCurrentDateTimeFixed(date(2010, 10, 13)); loan = createLoan(); loan.updateDetails(TestUtils.makeUserWithLocales()); // pay 3 installments makePayment(loan, "333.0"); loan.updateDetails(TestUtils.makeUserWithLocales()); makeEarlyPayment(loan); loan.updateDetails(TestUtils.makeUserWithLocales()); adjustLastLoanPayment(loan); loan.updateDetails(TestUtils.makeUserWithLocales()); assertNotNull("Account Status Change History Should Not Be Null", loan.getAccountStatusChangeHistory()); Integer listSize = loan.getAccountStatusChangeHistory().size(); assertFalse(listSize == 0); // check if the last entry has an oldstatus LOAN_CLOSED_OBLIGATIONS_MET and a new status of // LOAN_ACTIVE_IN_GOOD_STANDING AccountStateEntity oldStatus = loan.getAccountStatusChangeHistory().get(listSize - 1).getOldStatus(); AccountStateEntity newStatus = loan.getAccountStatusChangeHistory().get(listSize - 1).getNewStatus(); assertTrue("Old Status Should Have Been LOAN_CLOSED_OBLIGATIONS_MET", oldStatus .isInState(AccountState.LOAN_CLOSED_OBLIGATIONS_MET)); assertTrue("New Status Should Have Been LOAN_ACTIVE_IN_GOOD_STANDING", newStatus .isInState(AccountState.LOAN_ACTIVE_IN_GOOD_STANDING)); } @Test public void testWhenACompletedLoanIsAdjustedItGoesBackToBadStandingIfNecessary() throws Exception { // relates to mifos-3479 new DateTimeService().setCurrentDateTimeFixed(date(2010, 10, 13)); loan = createLoan(); loan.updateDetails(TestUtils.makeUserWithLocales()); // pay 3 installments makePayment(loan, "333.0"); loan.updateDetails(TestUtils.makeUserWithLocales()); makeEarlyPayment(loan); loan.updateDetails(TestUtils.makeUserWithLocales()); // ensure loan is in bad standing when reopened new DateTimeService().setCurrentDateTimeFixed(date(2010, 11, 13)); adjustLastLoanPayment(loan); loan.updateDetails(TestUtils.makeUserWithLocales()); AccountStateEntity currentStatus = loan.getAccountState(); assertTrue("Current Status Should Have Been LOAN_ACTIVE_IN_BAD_STANDING", currentStatus .isInState(AccountState.LOAN_ACTIVE_IN_BAD_STANDING)); } @Test public void testWhenARepaymentIsAdjustedItGoesBackToBadStandingIfNecessary() throws Exception { // relates to mifos-3479 new DateTimeService().setCurrentDateTimeFixed(date(2010, 10, 13)); loan = createLoan(); loan.updateDetails(TestUtils.makeUserWithLocales()); // pay 2 installments makePayment(loan, "222.0"); loan.updateDetails(TestUtils.makeUserWithLocales()); // pay 1 more installment makePayment(loan, "111.0"); loan.updateDetails(TestUtils.makeUserWithLocales()); // Ensure that after the adjustment the loan is calculated to be in bad standing. new DateTimeService().setCurrentDateTimeFixed(date(2010, 11, 13)); adjustLastLoanPayment(loan); loan.updateDetails(TestUtils.makeUserWithLocales()); assertNotNull("Account Status Change History Should Not Be Null", loan.getAccountStatusChangeHistory()); Integer listSize = loan.getAccountStatusChangeHistory().size(); assertFalse(listSize == 0); // check if the last entry has an oldstatus LOAN_ACTIVE_IN_GOOD_STANDING and a new status of // LOAN_ACTIVE_IN_BAD_STANDING AccountStateEntity oldStatus = loan.getAccountStatusChangeHistory().get(listSize - 1).getOldStatus(); AccountStateEntity newStatus = loan.getAccountStatusChangeHistory().get(listSize - 1).getNewStatus(); assertTrue("Old Status Should Have Been LOAN_ACTIVE_IN_GOOD_STANDING", oldStatus .isInState(AccountState.LOAN_ACTIVE_IN_GOOD_STANDING)); assertTrue("New Status Should Have Been LOAN_ACTIVE_IN_BAD_STANDING", newStatus .isInState(AccountState.LOAN_ACTIVE_IN_BAD_STANDING)); } private LoanBO createLoan() throws Exception { MeetingBO weeklyMeeting = new MeetingBuilder().customerMeeting().weekly().every(1).startingToday().build(); IntegrationTestObjectMother.saveMeeting(weeklyMeeting); center = new CenterBuilder().with(weeklyMeeting).withName("Center").with(sampleBranchOffice()).withLoanOfficer( testUser()).build(); IntegrationTestObjectMother.createCenter(center, weeklyMeeting); group = new GroupBuilder().withMeeting(weeklyMeeting).withName("Group").withOffice(sampleBranchOffice()) .withLoanOfficer(testUser()).withParentCustomer(center).build(); IntegrationTestObjectMother.createGroup(group, weeklyMeeting); client = new ClientBuilder().withMeeting(weeklyMeeting).withName("Client").withOffice(sampleBranchOffice()) .withLoanOfficer(testUser()).withParentCustomer(group).buildForIntegrationTests(); IntegrationTestObjectMother.createClient(client, weeklyMeeting); LoanOfferingBO loanOffering = new LoanProductBuilder().withName("Adjust Loan Product").withMeeting( weeklyMeeting).buildForIntegrationTests(); IntegrationTestObjectMother.createProduct(loanOffering); AmountFeeBO periodicFee = new FeeBuilder().appliesToLoans().periodic().withFeeAmount("10.0").withName( "Periodic Fee").with(sampleBranchOffice()).build(); IntegrationTestObjectMother.saveFee(periodicFee); BigDecimal loanAmount = BigDecimal.valueOf(Double.valueOf("1000.0")); BigDecimal minAllowedLoanAmount = loanAmount; BigDecimal maxAllowedLoanAmount = loanAmount; Double interestRate = loanOffering.getDefInterestRate(); LocalDate disbursementDate = new LocalDate(); int numberOfInstallments = 10; int minAllowedNumberOfInstallments = loanOffering.getEligibleInstallmentSameForAllLoan().getMaxNoOfInstall(); int maxAllowedNumberOfInstallments = loanOffering.getEligibleInstallmentSameForAllLoan().getMaxNoOfInstall(); int graceDuration = 0; Integer sourceOfFundId = null; Integer loanPurposeId = null; Integer collateralTypeId = null; String collateralNotes = null; String externalId = null; boolean repaymentScheduleIndependentOfCustomerMeeting = false; RecurringSchedule recurringSchedule = null; List<CreateAccountFeeDto> accountFees = new ArrayList<CreateAccountFeeDto>(); accountFees.add(new CreateAccountFeeDto(periodicFee.getFeeId().intValue(), periodicFee.getFeeAmount().toString())); CreateLoanAccount createLoanAccount = new CreateLoanAccount(client.getCustomerId(), loanOffering.getPrdOfferingId().intValue(), AccountState.LOAN_ACTIVE_IN_GOOD_STANDING.getValue().intValue(), loanAmount, minAllowedLoanAmount, maxAllowedLoanAmount, interestRate, disbursementDate, null, numberOfInstallments, minAllowedNumberOfInstallments, maxAllowedNumberOfInstallments, graceDuration, sourceOfFundId, loanPurposeId, collateralTypeId, collateralNotes, externalId, repaymentScheduleIndependentOfCustomerMeeting, recurringSchedule, accountFees, new ArrayList<CreateAccountPenaltyDto>()); return IntegrationTestObjectMother.createClientLoan(createLoanAccount); } private void makePayment(LoanBO loan, String amount) throws Exception { PaymentData paymentData = PaymentData.createPaymentData(new Money(loan.getCurrency(), amount), testUser(),(short) 1, new DateTime().toDate()); IntegrationTestObjectMother.applyAccountPayment(loan, paymentData); } private void makeEarlyPayment(LoanBO loan) throws AccountException { loan.makeEarlyRepayment(new AccountPaymentDto(loan.getEarlyRepayAmount().getAmount().doubleValue(), new DateTimeService().getCurrentJavaDateTime(), "", null, (short)1), testUser().getPersonnelId(), false, new Money(loan.getCurrency(), "0")); StaticHibernateUtil.flushSession(); } private void adjustLastLoanPayment(LoanBO loan) throws AccountException { PersonnelBO loggedInUser = IntegrationTestObjectMother.testUser(); loan.adjustLastPayment("Undo last payment", loggedInUser); StaticHibernateUtil.flushSession(); } private DateTime date(int year, int month, int day) { return new DateTime().withDate(year, month, day).toDateMidnight().toDateTime(); } private List<LoanInstallment> copyLoanSchedule(LoanBO loan) { List<LoanInstallment> copySchedule = new ArrayList<LoanInstallment>(); for (AccountActionDateEntity accountInstallment : loan.getAccountActionDates()) { LoanScheduleEntity loanInstallment = (LoanScheduleEntity) accountInstallment; copySchedule.add(new LoanInstallment(loanInstallment)); } return copySchedule; } private boolean sameSchedule(List<LoanInstallment> copySchedule, Set<AccountActionDateEntity> loanSchedule) { Integer index = 0; for (AccountActionDateEntity accountInstallment : loanSchedule) { if (copySchedule.get(index).different((LoanScheduleEntity) accountInstallment)) { return false; } index++; } return true; } private class LoanInstallment { private final Short installmentId; private final Date actionDate; private final Boolean isPaid; private final Date paymentDate; private final Money principal; private final Money interest; private final Money miscFee; private final Money miscPenalty; private final Money principalPaid; private final Money interestPaid; private Money miscFeePaid; private Money miscPenaltyPaid; private List<LoanFeeInstallment> loanFeeInstallments; public LoanInstallment(final LoanScheduleEntity loanInstallment) { this.installmentId = loanInstallment.getInstallmentId(); this.actionDate = loanInstallment.getActionDate(); this.isPaid = loanInstallment.isPaid(); this.paymentDate = loanInstallment.getPaymentDate(); this.principal = loanInstallment.getPrincipal(); this.interest = loanInstallment.getInterest(); this.miscFee = loanInstallment.getMiscFee(); this.miscPenalty = loanInstallment.getMiscPenalty(); this.principalPaid = loanInstallment.getPrincipalPaid(); this.interestPaid = loanInstallment.getInterestPaid(); this.miscFeePaid = loanInstallment.getMiscFeePaid(); this.miscPenaltyPaid = loanInstallment.getMiscPenaltyPaid(); if (loanInstallment.getAccountFeesActionDetails() != null) { loanFeeInstallments = new ArrayList<LoanFeeInstallment>(); for (AccountFeesActionDetailEntity accountFeesActionDetail : loanInstallment .getAccountFeesActionDetails()) { this.loanFeeInstallments.add(new LoanFeeInstallment(accountFeesActionDetail)); } } } public boolean different(LoanScheduleEntity loanInstallment) { // System.out.println("installmentId:" + this.installmentId + " - " + loanInstallment.getInstallmentId()); if (!this.installmentId.equals(loanInstallment.getInstallmentId())) { // System.out.println("installmentId different:" + this.installmentId + " - " + // loanInstallment.getInstallmentId()); return true; } if (!this.actionDate.equals(loanInstallment.getActionDate())) { // System.out.println("actionDate different:" + this.actionDate + " - " + // loanInstallment.getActionDate()); return true; } if (!this.isPaid.equals(loanInstallment.isPaid())) { // System.out.println("isPaid different:" + this.isPaid + " - " + loanInstallment.isPaid()); return true; } if ((this.paymentDate == null && loanInstallment.getPaymentDate() != null) || (this.paymentDate != null && loanInstallment.getPaymentDate() == null)) { System.out.println("paymentDate null/not null different"); return true; } if (this.paymentDate != null) { if (!this.paymentDate.equals(loanInstallment.getPaymentDate())) { System.out.println("paymentDate different:" + this.paymentDate + " - " + loanInstallment.getPaymentDate()); return true; } } if (!this.principal.equals(loanInstallment.getPrincipal())) { // System.out.println("principal different:" + this.principal + " - " + loanInstallment.getPrincipal()); return true; } if (!this.interest.equals(loanInstallment.getInterest())) { // System.out.println("interest different:" + this.interest + " - " + loanInstallment.getInterest()); return true; } if (!this.miscFee.equals(loanInstallment.getMiscFee())) { // System.out.println("miscFee different:" + this.miscFee + " - " + loanInstallment.getMiscFee()); return true; } if (!this.miscPenalty.equals(loanInstallment.getMiscPenalty())) { // System.out.println("miscPenalty different:" + this.miscPenalty + " - " + // loanInstallment.getMiscPenalty()); return true; } if (!this.principalPaid.equals(loanInstallment.getPrincipalPaid())) { // System.out.println("principalPaid different:" + this.principalPaid + " - " + // loanInstallment.getPrincipalPaid()); return true; } if (!this.interestPaid.equals(loanInstallment.getInterestPaid())) { // System.out.println("interestPaid different:" + this.interestPaid + " - " + // loanInstallment.getInterestPaid()); return true; } if (!this.miscFeePaid.equals(loanInstallment.getMiscFeePaid())) { // System.out.println("miscFeePaid different:" + this.miscFeePaid + " - " + // loanInstallment.getMiscFeePaid()); return true; } if (!this.miscPenaltyPaid.equals(loanInstallment.getMiscPenaltyPaid())) { // System.out.println("miscPenaltyPaid different:" + this.miscPenaltyPaid + " - " + // loanInstallment.getMiscPenaltyPaid()); return true; } if ((this.loanFeeInstallments == null && loanInstallment.getAccountFeesActionDetails() != null) || (this.loanFeeInstallments != null && loanInstallment.getAccountFeesActionDetails() == null)) { // System.out.println("Loan Fee Installment null/not null different"); return true; } if (loanInstallment.getAccountFeesActionDetails() != null) { Integer index = 0; for (AccountFeesActionDetailEntity accountFeesActionDetail : loanInstallment .getAccountFeesActionDetails()) { if (this.loanFeeInstallments.get(index).different(accountFeesActionDetail)) { return true; } index++; } } return false; } } private class LoanFeeInstallment { private final Money feeAmount; private final Money feeAmountPaid; public LoanFeeInstallment(final AccountFeesActionDetailEntity feeInstallment) { this.feeAmount = feeInstallment.getFeeAmount(); this.feeAmountPaid = feeInstallment.getFeeAmountPaid(); } public boolean different(AccountFeesActionDetailEntity accountFeesActionDetail) { // System.out.println("checking fees"); if (!this.feeAmount.equals(accountFeesActionDetail.getFeeAmount())) { // System.out.println("feeAmount different:" + this.feeAmount + " - " + // accountFeesActionDetail.getFeeAmount()); return true; } if (!this.feeAmountPaid.equals(accountFeesActionDetail.getFeeAmountPaid())) { // System.out.println("feeAmountPaid different:" + this.feeAmountPaid + " - " + // accountFeesActionDetail.getFeeAmountPaid()); return true; } return false; } } }