/* * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package com.facebook.presto.sql.planner.optimizations; import com.facebook.presto.spi.type.Type; import com.facebook.presto.sql.parser.SqlParser; import com.facebook.presto.sql.planner.DependencyExtractor; import com.facebook.presto.sql.planner.PlanNodeIdAllocator; import com.facebook.presto.sql.planner.Symbol; import com.facebook.presto.sql.planner.SymbolAllocator; import com.facebook.presto.sql.planner.plan.FilterNode; import com.facebook.presto.sql.planner.plan.ValuesNode; import com.facebook.presto.sql.tree.Expression; import com.facebook.presto.sql.tree.ExpressionRewriter; import com.facebook.presto.sql.tree.ExpressionTreeRewriter; import com.facebook.presto.sql.tree.LogicalBinaryExpression; import org.testng.annotations.Test; import java.util.List; import java.util.Map; import java.util.stream.Collectors; import static com.facebook.presto.SessionTestUtils.TEST_SESSION; import static com.facebook.presto.metadata.MetadataManager.createTestMetadataManager; import static com.facebook.presto.spi.type.BooleanType.BOOLEAN; import static com.facebook.presto.sql.ExpressionUtils.binaryExpression; import static com.facebook.presto.sql.ExpressionUtils.extractPredicates; import static com.facebook.presto.sql.ExpressionUtils.rewriteIdentifiersToSymbolReferences; import static java.util.Collections.emptyList; import static java.util.stream.Collectors.toList; import static org.testng.Assert.assertEquals; public class TestSimplifyExpressions { private static final SqlParser SQL_PARSER = new SqlParser(); private static final SimplifyExpressions SIMPLIFIER = new SimplifyExpressions(createTestMetadataManager(), SQL_PARSER); @Test public void testPushesDownNegations() { assertSimplifies("NOT X", "NOT X"); assertSimplifies("NOT NOT X", "X"); assertSimplifies("NOT NOT NOT X", "NOT X"); assertSimplifies("NOT NOT NOT X", "NOT X"); assertSimplifies("NOT (X > Y)", "X <= Y"); assertSimplifies("NOT (X > (NOT NOT Y))", "X <= Y"); assertSimplifies("X > (NOT NOT Y)", "X > Y"); assertSimplifies("NOT (X AND Y AND (NOT (Z OR V)))", "(NOT X) OR (NOT Y) OR (Z OR V)"); assertSimplifies("NOT (X OR Y OR (NOT (Z OR V)))", "(NOT X) AND (NOT Y) AND (Z OR V)"); assertSimplifies("NOT (X OR Y OR (Z OR V))", "(NOT X) AND (NOT Y) AND ((NOT Z) AND (NOT V))"); assertSimplifies("NOT (X IS DISTINCT FROM Y)", "NOT (X IS DISTINCT FROM Y)"); } @Test public void testExtractCommonPredicates() { assertSimplifies("X AND Y", "X AND Y"); assertSimplifies("X OR Y", "X OR Y"); assertSimplifies("X AND X", "X"); assertSimplifies("X OR X", "X"); assertSimplifies("(X OR Y) AND (X OR Y)", "X OR Y"); assertSimplifies("(A AND V) OR V", "V"); assertSimplifies("(A OR V) AND V", "V"); assertSimplifies("(A OR B OR C) AND (A OR B)", "A OR B"); assertSimplifies("(A AND B) OR (A AND B AND C)", "A AND B"); assertSimplifies("I = ((A OR B) AND (A OR B OR C))", "I = (A OR B)"); assertSimplifies("(X OR Y) AND (X OR Z)", "(X OR Y) AND (X OR Z)"); assertSimplifies("(X AND Y AND V) OR (X AND Y AND Z)", "(X AND Y) AND (V OR Z)"); assertSimplifies("((X OR Y OR V) AND (X OR Y OR Z)) = I", "((X OR Y) OR (V AND Z)) = I"); assertSimplifies("((X OR V) AND V) OR ((X OR V) AND V)", "V"); assertSimplifies("((X OR V) AND X) OR ((X OR V) AND V)", "X OR V"); assertSimplifies("((X OR V) AND Z) OR ((X OR V) AND V)", "(X OR V) AND (Z OR V)"); assertSimplifies("X AND ((Y AND Z) OR (Y AND V) OR (Y AND X))", "X AND Y AND (Z OR V OR X)"); assertSimplifies("(A AND B AND C AND D) OR (A AND B AND E) OR (A AND F)", "A AND ((B AND C AND D) OR (B AND E) OR F)"); assertSimplifies("((A AND B) OR (A AND C)) AND D", "A AND (B OR C) AND D"); assertSimplifies("((A OR B) AND (A OR C)) OR D", "(A OR B OR D) AND (A OR C OR D)"); assertSimplifies("(((A AND B) OR (A AND C)) AND D) OR E", "(A OR E) AND (B OR C OR E) AND (D OR E)"); assertSimplifies("(((A OR B) AND (A OR C)) OR D) AND E", "(A OR (B AND C) OR D) AND E"); assertSimplifies("(A AND B) OR (C AND D)", "(A OR C) AND (A OR D) AND (B OR C) AND (B OR D)"); // No distribution since it would add too many new terms assertSimplifies("(A AND B) OR (C AND D) OR (E AND F)", "(A AND B) OR (C AND D) OR (E AND F)"); // Test overflow handling for large disjunct expressions assertSimplifies("(A1 AND A2) OR (A3 AND A4) OR (A5 AND A6) OR (A7 AND A8) OR (A9 AND A10)" + " OR (A11 AND A12) OR (A13 AND A14) OR (A15 AND A16) OR (A17 AND A18) OR (A19 AND A20)" + " OR (A21 AND A22) OR (A23 AND A24) OR (A25 AND A26) OR (A27 AND A28) OR (A29 AND A30)" + " OR (A31 AND A32) OR (A33 AND A34) OR (A35 AND A36) OR (A37 AND A38) OR (A39 AND A40)" + " OR (A41 AND A42) OR (A43 AND A44) OR (A45 AND A46) OR (A47 AND A48) OR (A49 AND A50)" + " OR (A51 AND A52) OR (A53 AND A54) OR (A55 AND A56) OR (A57 AND A58) OR (A59 AND A60)", "(A1 AND A2) OR (A3 AND A4) OR (A5 AND A6) OR (A7 AND A8) OR (A9 AND A10)" + " OR (A11 AND A12) OR (A13 AND A14) OR (A15 AND A16) OR (A17 AND A18) OR (A19 AND A20)" + " OR (A21 AND A22) OR (A23 AND A24) OR (A25 AND A26) OR (A27 AND A28) OR (A29 AND A30)" + " OR (A31 AND A32) OR (A33 AND A34) OR (A35 AND A36) OR (A37 AND A38) OR (A39 AND A40)" + " OR (A41 AND A42) OR (A43 AND A44) OR (A45 AND A46) OR (A47 AND A48) OR (A49 AND A50)" + " OR (A51 AND A52) OR (A53 AND A54) OR (A55 AND A56) OR (A57 AND A58) OR (A59 AND A60)"); } private static void assertSimplifies(String expression, String expected) { Expression actualExpression = rewriteIdentifiersToSymbolReferences(SQL_PARSER.createExpression(expression)); Expression expectedExpression = rewriteIdentifiersToSymbolReferences(SQL_PARSER.createExpression(expected)); assertEquals( normalize(simplifyExpressions(actualExpression)), normalize(expectedExpression)); } private static Expression simplifyExpressions(Expression expression) { PlanNodeIdAllocator planNodeIdAllocator = new PlanNodeIdAllocator(); FilterNode filterNode = new FilterNode( planNodeIdAllocator.getNextId(), new ValuesNode(planNodeIdAllocator.getNextId(), emptyList(), emptyList()), expression); FilterNode simplifiedNode = (FilterNode) SIMPLIFIER.optimize( filterNode, TEST_SESSION, booleanSymbolTypeMapFor(expression), new SymbolAllocator(), planNodeIdAllocator); return simplifiedNode.getPredicate(); } private static Map<Symbol, Type> booleanSymbolTypeMapFor(Expression expression) { return DependencyExtractor.extractUnique(expression).stream() .collect(Collectors.toMap(symbol -> symbol, symbol -> BOOLEAN)); } private static Expression normalize(Expression expression) { return ExpressionTreeRewriter.rewriteWith(new NormalizeExpressionRewriter(), expression); } private static class NormalizeExpressionRewriter extends ExpressionRewriter<Void> { @Override public Expression rewriteLogicalBinaryExpression(LogicalBinaryExpression node, Void context, ExpressionTreeRewriter<Void> treeRewriter) { List<Expression> predicates = extractPredicates(node.getType(), node).stream() .map(p -> treeRewriter.rewrite(p, context)) .sorted((p1, p2) -> p1.toString().compareTo(p2.toString())) .collect(toList()); return binaryExpression(node.getType(), predicates); } } }