/**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.rules;
import net.sourceforge.pmd.AbstractRule;
import net.sourceforge.pmd.RuleContext;
import net.sourceforge.pmd.ast.ASTPrimitiveType;
import net.sourceforge.pmd.ast.ASTVariableDeclaratorId;
import net.sourceforge.pmd.ast.SimpleNode;
import net.sourceforge.pmd.symboltable.NameOccurrence;
import net.sourceforge.pmd.symboltable.VariableNameDeclaration;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
public class StringToStringRule extends AbstractRule {
public Object visit(ASTVariableDeclaratorId node, Object data) {
SimpleNode nameNode = node.getTypeNameNode();
if (nameNode instanceof ASTPrimitiveType || !nameNode.getImage().equals("String")) {
return data;
}
// now we know we're at a variable declaration of type String
Map decls = node.getScope().getVariableDeclarations(true);
for (Iterator i = decls.keySet().iterator(); i.hasNext();) {
VariableNameDeclaration decl = (VariableNameDeclaration) i.next();
if (!decl.getImage().equals(node.getImage())) {
continue;
}
List usages = (List) decls.get(decl);
for (Iterator j = usages.iterator(); j.hasNext();) {
NameOccurrence occ = (NameOccurrence) j.next();
if (occ.getNameForWhichThisIsAQualifier() != null && occ.getNameForWhichThisIsAQualifier().getImage().indexOf("toString") != -1) {
RuleContext ctx = (RuleContext) data;
ctx.getReport().addRuleViolation(createRuleViolation(ctx, occ.getBeginLine()));
}
}
}
return data;
}
}