/* * SonarQube Java * Copyright (C) 2012-2016 SonarSource SA * mailto:contact AT sonarsource DOT com * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 3 of the License, or (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public License * along with this program; if not, write to the Free Software Foundation, * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ package org.sonar.java.checks.naming; import com.google.common.collect.Lists; import org.sonar.check.Rule; import org.sonar.plugins.java.api.JavaFileScanner; import org.sonar.plugins.java.api.JavaFileScannerContext; import org.sonar.plugins.java.api.semantic.Symbol; import org.sonar.plugins.java.api.tree.BaseTreeVisitor; import org.sonar.plugins.java.api.tree.ClassTree; import org.sonar.plugins.java.api.tree.IdentifierTree; import org.sonar.plugins.java.api.tree.Tree; import org.sonar.plugins.java.api.tree.VariableTree; import java.util.Collection; @Rule(key = "S1700") public class FieldNameMatchingTypeNameCheck extends BaseTreeVisitor implements JavaFileScanner { private JavaFileScannerContext context; private String currentClassName; private Collection<Tree> fields; @Override public void scanFile(JavaFileScannerContext context) { this.context = context; currentClassName = ""; fields = Lists.newArrayList(); if (context.getSemanticModel() != null) { scan(context.getTree()); } } @Override public void visitClass(ClassTree tree) { IdentifierTree simpleName = tree.simpleName(); if (simpleName != null) { Symbol.TypeSymbol classSymbol = tree.symbol(); Collection<Symbol> members = classSymbol.memberSymbols(); for (Symbol sym : members) { if (sym.isVariableSymbol() && !staticFieldSameType(classSymbol, sym)) { //Exclude static fields of the same type. fields.add(((Symbol.VariableSymbol) sym).declaration()); } } currentClassName = simpleName.name(); } super.visitClass(tree); currentClassName = ""; fields.clear(); } private static boolean staticFieldSameType(Symbol classSymbol, Symbol sym) { return sym.type().equals(classSymbol.type()) && sym.isStatic(); } @Override public void visitVariable(VariableTree tree) { String name = tree.simpleName().name(); if (fields.contains(tree) && currentClassName.equalsIgnoreCase(name)) { context.reportIssue(this, tree.simpleName(), "Rename field \"" + name + "\""); } super.visitVariable(tree); } }