/* * The MIT License * * Copyright 2013 Red Hat, Inc. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal * in the Software without restriction, including without limitation the rights * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell * copies of the Software, and to permit persons to whom the Software is * furnished to do so, subject to the following conditions: * * The above copyright notice and this permission notice shall be included in * all copies or substantial portions of the Software. * * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * THE SOFTWARE. */ package hudson.cli; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.containsString; import static org.hamcrest.Matchers.equalTo; import static org.hamcrest.Matchers.nullValue; import static hudson.cli.CLICommandInvoker.Matcher.failedWith; import static hudson.cli.CLICommandInvoker.Matcher.hasNoStandardOutput; import static hudson.cli.CLICommandInvoker.Matcher.succeededSilently; import hudson.model.Computer; import hudson.model.Node; import jenkins.model.Jenkins; import org.junit.Before; import org.junit.Rule; import org.junit.Test; import org.jvnet.hudson.test.Issue; import org.jvnet.hudson.test.JenkinsRule; public class UpdateNodeCommandTest { private CLICommandInvoker command; @Rule public final JenkinsRule j = new JenkinsRule(); @Before public void setUp() { command = new CLICommandInvoker(j, new UpdateNodeCommand()); } @Test public void updateNodeShouldFailWithoutComputerConfigurePermission() throws Exception { j.createSlave("MySlave", null, null); final CLICommandInvoker.Result result = command .authorizedTo(Jenkins.READ) .invokeWithArgs("MySlave") ; assertThat(result.stderr(), containsString("ERROR: user is missing the Agent/Configure permission")); assertThat(result, failedWith(6)); assertThat(result, hasNoStandardOutput()); } @Test public void updateNodeShouldModifyNodeConfiguration() throws Exception { j.createSlave("MySlave", null, null); final CLICommandInvoker.Result result = command .authorizedTo(Computer.CONFIGURE, Jenkins.READ) .withStdin(Computer.class.getResourceAsStream("node.xml")) .invokeWithArgs("MySlave") ; assertThat(result, succeededSilently()); assertThat("A slave with old name should not exist", j.jenkins.getNode("MySlave"), nullValue()); final Node updatedSlave = j.jenkins.getNode("SlaveFromXML"); assertThat(updatedSlave.getNodeName(), equalTo("SlaveFromXML")); assertThat(updatedSlave.getNumExecutors(), equalTo(42)); } @Test public void updateNodeShouldFailIfNodeDoesNotExist() throws Exception { final CLICommandInvoker.Result result = command .authorizedTo(Computer.CONFIGURE, Jenkins.READ) .withStdin(Computer.class.getResourceAsStream("node.xml")) .invokeWithArgs("MySlave") ; assertThat(result.stderr(), containsString("ERROR: No such node 'MySlave'")); assertThat(result, failedWith(3)); assertThat(result, hasNoStandardOutput()); } @Issue("SECURITY-281") @Test public void updateNodeShouldFailForMaster() throws Exception { CLICommandInvoker.Result result = command.authorizedTo(Computer.CONFIGURE, Jenkins.READ).withStdin(Computer.class.getResourceAsStream("node.xml")).invokeWithArgs(""); assertThat(result.stderr(), containsString("No such node ''")); assertThat(result, failedWith(3)); assertThat(result, hasNoStandardOutput()); result = command.authorizedTo(Computer.EXTENDED_READ, Jenkins.READ).withStdin(Computer.class.getResourceAsStream("node.xml")).invokeWithArgs("(master)"); assertThat(result.stderr(), containsString("No such node '(master)'")); assertThat(result, failedWith(3)); assertThat(result, hasNoStandardOutput()); } }