PylintResultParserTest.java

package pl.touk.sputnik.processor.pylint;

import com.google.common.io.Resources;
import junitparams.JUnitParamsRunner;
import junitparams.Parameters;
import org.apache.commons.io.IOUtils;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
import pl.touk.sputnik.review.Severity;
import pl.touk.sputnik.review.Violation;

import java.io.IOException;
import java.net.URISyntaxException;
import java.util.List;

import static org.assertj.core.api.Assertions.assertThat;
import static org.hamcrest.core.StringStartsWith.startsWith;

@RunWith(JUnitParamsRunner.class)
public class PylintResultParserTest {

    private PylintResultParser pylintResultParser;

    @Rule
    public ExpectedException thrown = ExpectedException.none();

    @Before
    public void setUp() {
        pylintResultParser = new PylintResultParser();
    }

    @Test
    @Parameters({
            "pylint/sample-output.txt",
            "pylint/sample-output-no-header.txt"
    })
    public void shouldParseSampleViolations(String filePath) throws IOException, URISyntaxException {
        // given
        String response = IOUtils.toString(Resources.getResource(filePath).toURI());

        // when
        List<Violation> violations = pylintResultParser.parse(response);

        // then
        assertThat(violations).hasSize(8);
        assertThat(violations).extracting("filenameOrJavaClassName").contains("PythonTest.py");
        assertThat(violations)
                .extracting("message")
                .contains("Invalid argument name \"n\" [invalid-name]")
                .contains("Black listed name \"bar\" [blacklisted-name]")
                .contains("Black listed name \"foo\" [blacklisted-name]");
    }

    @Test
    public void shouldParseMessageTypes() throws IOException, URISyntaxException {
        // given
        String response = IOUtils.toString(Resources.getResource("pylint/output-with-many-message-types.txt").toURI());

        // when
        List<Violation> violations = pylintResultParser.parse(response);

        // then
        assertThat(violations).hasSize(4);
        assertThat(violations)
                .extracting("severity")
                .containsExactly(Severity.INFO, Severity.INFO,  Severity.WARNING, Severity.ERROR);
    }

    @Test
    public void shouldThrowExceptionWhenFatalPylintErrorOccurs() throws IOException, URISyntaxException {
        // given
        String response = IOUtils.toString(Resources.getResource("pylint/output-with-fatal.txt").toURI());

        thrown.expect(PylintException.class);
        thrown.expectMessage(startsWith("Fatal error from pylint"));
        pylintResultParser.parse(response);
    }
}