/** * Find Security Bugs * Copyright (c) Philippe Arteau, All rights reserved. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 3.0 of the License, or (at your option) any later version. * * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public * License along with this library. */ package com.h3xstream.findsecbugs.csrf; import com.h3xstream.findbugs.test.BaseDetectorTest; import com.h3xstream.findbugs.test.EasyBugReporter; import org.testng.annotations.Test; import static org.mockito.Mockito.never; import static org.mockito.Mockito.spy; import static org.mockito.Mockito.times; import static org.mockito.Mockito.verify; public class SpringCsrfUnrestrictedRequestMappingDetectorTest extends BaseDetectorTest { @Test public void detectSpringCsrfUnrestrictedRequestMapping() throws Exception { //Locate test code String[] files = { getClassFilePath("testcode/csrf/UnsafeSpringCsrfRequestMappingController") }; //Run the analysis EasyBugReporter reporter = spy(new SecurityReporter()); analyze(files, reporter); //Assertions verify(reporter).doReportBug( bugDefinition().bugType("SPRING_CSRF_UNRESTRICTED_REQUEST_MAPPING").inMethod("requestMappingNoMethod").build()); verify(reporter).doReportBug( bugDefinition().bugType("SPRING_CSRF_UNRESTRICTED_REQUEST_MAPPING").inMethod("requestMappingEmptyMethod").build()); verify(reporter).doReportBug( bugDefinition().bugType("SPRING_CSRF_UNRESTRICTED_REQUEST_MAPPING").inMethod("requestMappingUnprotectedAndProtectedMethods").build()); verify(reporter).doReportBug( bugDefinition().bugType("SPRING_CSRF_UNRESTRICTED_REQUEST_MAPPING").inMethod("requestMappingUnprotectedAndProtectedUncommonMethods").build()); verify(reporter).doReportBug( bugDefinition().bugType("SPRING_CSRF_UNRESTRICTED_REQUEST_MAPPING").inMethod("requestMappingAllUnprotectedMethodsAndOneProtectedMethod").build()); verify(reporter).doReportBug( bugDefinition().bugType("SPRING_CSRF_UNRESTRICTED_REQUEST_MAPPING").inMethod("requestMappingAllProtectedMethodsAndOneUnprotectedMethod").build()); verify(reporter, times(6)).doReportBug( bugDefinition().bugType("SPRING_CSRF_UNRESTRICTED_REQUEST_MAPPING").build()); } @Test public void avoidFalsePositiveOnSafeSpringCsrfRequestMapping() throws Exception { //Locate test code String[] files = { getClassFilePath("testcode/csrf/SafeSpringCsrfRequestMappingController") }; //Run the analysis EasyBugReporter reporter = spy(new SecurityReporter()); analyze(files, reporter); //Assertions verify(reporter, never()).doReportBug( bugDefinition().bugType("SPRING_CSRF_UNRESTRICTED_REQUEST_MAPPING").build()); } }